This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Get protofiles from SDK release. Remove Makefile.#52
Merged
Conversation
juanjux
force-pushed
the
feature/nomakefile
branch
2 times, most recently
from
f4163d3 to
067b20f
Compare
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
juanjux
force-pushed
the
feature/nomakefile
branch
from
c8edd54 to
3fe8392
Compare
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
juanjux
force-pushed
the
feature/nomakefile
branch
from
60fa7c2 to
c8ef2e7
Compare
abeaumont
approved these changes
Nov 2, 2017
Contributor
abeaumont
left a comment
abeaumont
left a comment
There was a problem hiding this comment.
Having to build protobuf (and taking so long) looks bad, it'd be great if we can improve that.
| "Programming Language :: Python :: 3.6", | ||
| "Topic :: Software Development :: Libraries" | ||
| LIBUAST_VERSION = "v1.3.0" | ||
| SDK_MAJOR = "v1" |
Contributor
There was a problem hiding this comment.
minor: this could be extracted from SDK_VERSION and remove the possibility of setting incompatible versions.
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Contributor
Author
|
Yes, I'll look today into compiling it in an Ubuntu 14.04 VM or container and uploading it to google drive. |
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Contributor
Author
|
@abeaumont fixed the compiling kludge, I compiled a deb package for 14.04 and since it seem there isn't an easy/elegant way to download a file non interactively from gdriver, I uploaded the deb in a release in this same repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36.
Also compiles protobuf from sources on the Travis build since there aren't packages from it for Travis' Ubuntu 14.04. I'm not totally satisfied with it since it takes now 24 minutes to complete the build, I'll investigate options to upload a precompiled package somewhere and retrieve it on build.
Signed-off-by: Juanjo Alvarez juanjo@sourced.tech