This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Remove msgpack dependency #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeaumont
reviewed
Jul 12, 2017
| format_ = 'msgpack' | ||
| else: | ||
| format_ = 'json' | ||
| format_ = 'json' |
Contributor
There was a problem hiding this comment.
In line 52 format is used instead of format_, should they be the same?
Contributor
Author
There was a problem hiding this comment.
Oh yes, that's a bug (twice actually, it's also used as format in the other exception message), fixed, thanks.
| format_ = 'json' | ||
| format_ = 'json' | ||
|
|
||
| processor, inbuffer = get_processor_instance(format_) |
Contributor
There was a problem hiding this comment.
Is this factory method (and the whole processor, its config, etc.) needed anymore? I'd remove it if not (it can always be restored in the future if needed again), but as you prefer.
Contributor
Author
There was a problem hiding this comment.
@smola requested some time ago that the json processor would be injected as a dependency trough I'm personally more of the YAGNI approach to these things but for the moment I would prefer to leave it that way.
abeaumont
approved these changes
Jul 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.