Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Conversation

@juanjux
Copy link
Contributor

@juanjux juanjux commented Aug 11, 2017

  • Upgrade pydetector dependency to 0.12.0 (which fixes several positioning problems).
  • Added regression tests for Decorators have the same line number as the functions they decorate #63 and Snippet produces wrong offset #65.
  • Many annotations fixes:
    • Fixed import annotations and identifiers.
    • Remove several unneded promoted lists.
    • Moved some annotations out of child lists to the top level since they were the
      same under all the parents.
    • Added Incomplete to ClassDef keywords (metaclass=bla, etc).
    • Removed temporal files and directories from the integration tests that were in git.

Fixes #63
Fixes #65

- Many annotations fixes:
  - Fixed import annotations and identifiers
  - Remove several unneded promoted lists
  - Moved some annotations out of child lists to the top level since they were the
    same under all the parents.
  - Added Incomplete to ClassDef keywords (metaclas=bla, etc)
  - Removed temporal files and directories from the integration tests that were in git

Fixes #63
Fixes #65
@juanjux juanjux changed the title - Upgrade pydetector dependency to 0.12.0 Many annotation fixes, pydetector dependency upgraded Aug 11, 2017
@@ -1,0 +1,186 @@
| Path | Action |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this file was removed? :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not removed but the last release left it empty for some reason...

. . . . . . . . asname: <nil>
. . . . . . . }
. . . . . . }
. . . . . . asname: <nil>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected?

Copy link
Contributor Author

@juanjux juanjux Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, is in the part of the native properties of the node and is None in Python (is the property that maps y in import x as y, it's always present even for import x without alias).

@juanjux juanjux merged commit 0a9f716 into bblfsh:master Aug 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snippet produces wrong offset Decorators have the same line number as the functions they decorate

2 participants