Skip to content

add .maintainer.yaml with prReviewer.autoApprove#10

Merged
bborbe merged 1 commit into
masterfrom
feat/seed-maintainer-yaml
May 29, 2026
Merged

add .maintainer.yaml with prReviewer.autoApprove#10
bborbe merged 1 commit into
masterfrom
feat/seed-maintainer-yaml

Conversation

@bborbe
Copy link
Copy Markdown
Owner

@bborbe bborbe commented May 29, 2026

Summary

  • Adds .maintainer.yaml with prReviewer.autoApprove: true, migrating pr-reviewer trust config from the legacy .pr-reviewer.yaml.
  • Keeps .pr-reviewer.yaml for now — the currently-deployed prod bot still reads it. Removed in a follow-up once the new pr-reviewer image is deployed.

Test plan

  • pr-reviewer bot APPROVE + green checks

Migrates pr-reviewer trust config from legacy .pr-reviewer.yaml to the
shared .maintainer.yaml schema. Keeps .pr-reviewer.yaml until the new
pr-reviewer image is deployed to prod; legacy file removed in follow-up.
Copy link
Copy Markdown

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my review, here's the analysis:

Diff Summary: Single file added - .maintainer.yaml with 15 lines (comments + config)

Review Findings:

The .maintainer.yaml file adds prReviewer.autoApprove: true configuration with inline documentation explaining:

  • When autoApprove: true, the verdict "approve" posts as an APPROVE (counts toward branch protection)
  • When false/absent, it demotes to COMMENT
  • This replaces a legacy .pr-reviewer.yaml file

Concerns Assessment:

  • Security: The autoApprove setting is explicitly documented in the file comments, explaining its effect on PR verdicts. The PR appears intentional.
  • YAML correctness: Structure is valid, simple boolean value under prReviewer key.

No automated checks failed (no precommit target in root Makefile, LICENSE file exists)

{
  "verdict": "approve",
  "summary": "Single-file PR adding .maintainer.yaml with prReviewer.autoApprove: true. The configuration is self-documenting with inline comments explaining the security implications (auto-approval counts toward branch protection). YAML structure is valid and correctly formatted.",
  "comments": [],
  "concerns_addressed": [
    "security: autoApprove behavior documented in file comments — explains APPROVE vs COMMENT behavior",
    "correctness: YAML structure is valid with simple prReviewer.autoApprove boolean"
  ]
}

@bborbe bborbe merged commit 0bde854 into master May 29, 2026
4 of 9 checks passed
@bborbe bborbe deleted the feat/seed-maintainer-yaml branch May 29, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant