fix(parser): accept asterisk list-marker on checkbox regex

[bborbe]

Summary

Unifies the seven checkbox regex sites across pkg/storage and pkg/ops so both - [ ] and * [ ] (and their [x] / [/] variants) are accepted as Markdown task lines, matching the linter's pre-existing tolerance for both markers. Closes the silent-skip bug where complete-goal / complete-task / update-task / defer-task / work-on-task ignored asterisk-prefixed checkboxes that the linter just declared fine.

The single replacement site in pkg/ops/complete.go captures the original list marker (([-*])) and reuses it via $1, so a * [/] line becomes * [x], not - [x].

8 vault files in the active personal vault use the asterisk form and become correctly visible to all ops.

Test plan

• go test ./pkg/storage/... ./pkg/ops/... exits 0 (new asterisk cases added to each _test.go)
• git grep -nE '\^\(\\s\*\)- \\\[' pkg/storage/base.go pkg/ops/update.go pkg/ops/complete.go pkg/ops/defer.go pkg/ops/workon.go returns zero matches
• git grep -nE '\(\[-\*\]\) \[' pkg/ops/complete.go returns one match (the capture-group replacement site)
• make precommit exits 0
• Pre-existing dash-form test cases pass unchanged

Spec: dark-factory/specs/completed/020-unify-checkbox-regex-accept-asterisk-prefix.md.

[ben-s-pull-request-reviewer]

Based on the complete diff analysis, here's my review:

PR Review: fix(parser): accept asterisk list-marker on checkbox regex

Verdict: approve

Summary

The PR correctly extends the checkbox regex to accept * as an alternative list marker alongside - across all 7 detection sites and 2 replacement sites. New tests guard against marker-rewrite regressions. No issues found.

---

Must Fix (Critical)

None.

Should Fix (Important)

None.

Nice to Have (Optional)

None.

---

Detailed Analysis

Regex changes (7 detection sites): All correctly changed from - \[ to [-*] \[, preserving capture group indices. No downstream code relies on the old group structure — matches[2] still holds checkbox state, matches[3] still holds task text across all callers.

complete.go replacement sites (2 branches):

• Check branch: ([-*]) \[([ /])\] → $1 [x] — correctly captures and reuses marker
• Uncheck branch: ([-*]) \[x\] → $1 [ ] — correctly captures and reuses marker
• No cross-contamination: * [x] stays * [x], - [x] stays - [x]

workon.go: Uses matches[1] (the captured marker) in strings.Replace(line, marker+" [ ]", marker+" [/]", 1). The regex ^(\s*)[-*] \[([ x/])\] (.+)$ means matches[1] is exactly - or * (no whitespace), so replacement is correct.

lint.go: Confirmed untouched — it was excluded per spec and the diff shows no changes to it.

Test coverage: New Ginkgo contexts added to complete_test.go, workon_test.go, defer_test.go, update_test.go, and markdown_test.go. Each guards specifically against marker rewrite (verifying * [/] becomes * [x], not - [x]).

CHANGELOG.md: ## Unreleased section added with correct fix description.

---

{
  "verdict": "approve",
  "summary": "The PR correctly extends the checkbox regex to accept '*' as an alternative list marker across all detection and replacement sites. Tests guard against marker-rewrite regressions. No issues found.",
  "comments": [],
  "concerns_addressed": [
    "correctness: complete.go replacement regex correctly captures and reuses marker via $1 — no cross-contamination",
    "correctness: workon.go uses matches[1] (the captured marker) correctly — marker is '-' or '*' only, not whitespace",
    "correctness: base.go checkboxRegex changed from '-' to '[-*]' — all callers use consistent capture group indices",
    "tests: complete_test.go new context verifies '* [x]' is produced, not '- [x]'",
    "tests: workon_test.go new context verifies '* [/]' preserves asterisk from '* [ ]'",
    "correctness: lint.go NOT modified — confirmed by diff (excluded per spec)"
  ]
}