fix(ui): break panes before toggling dangerous mode to prevent duplicates#313
Merged
fix(ui): break panes before toggling dangerous mode to prevent duplicates#313
Conversation
…ates When toggling dangerous/safe mode while viewing a task, the Claude pane is joined to task-ui. The executor's killAllWindowsByNameAllSessions only kills windows in daemon sessions, so the pane in task-ui survived. This left the old Claude running while a new one was created, resulting in duplicate executor panes (2 Claudes + 2 shells = 4 panes). Fix: Call Cleanup() on the detail view before toggling to break panes back to the daemon window. Then the executor's kill finds and terminates them properly before creating the new window. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task-uiweren't killed bykillAllWindowsByNameAllSessions(which only kills daemon windows)Cleanup()before toggling to break panes back to daemon firstTest plan
D🤖 Generated with Claude Code