Fix permission quick input not submitting to executor#474
Merged
Conversation
SendKeyToPane was sending just the key character ("y" or "n") without
pressing Enter afterward. All terminal-based permission prompts require
Enter to submit the response. Every other send-keys usage in the
executor already includes "Enter" (e.g., "continue working", "Enter").
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendKeyToPanewas sending just the key character ("y"or"n") without pressing Enter afterwardsend-keysusage in the executor already includes"Enter"(e.g., sending"continue working", "Enter")Analysis
latestPermissionPrompt()which checks for"Waiting for permission"log entries)tasksNeedingInputmap is only populated for permission prompts, not for general MCPtaskyou_needs_inputquestionsSendKeyToPaneis executor-agnostic (sends tmux keystrokes to whatever's running in the pane), and Enter is universally needed for all terminal prompts regardless of executor type (Claude, Codex, Gemini, etc.)Test plan
go test ./internal/ui/)go test ./internal/executor/)go build ./...)🤖 Generated with Claude Code