Harden non-git project support: security, DRY, tests#485
Merged
Conversation
Follow-up to #484 addressing review findings: 1. Security: isValidWorkDir now requires an explicit allowedProjectDir parameter instead of accepting any existing directory. createTmuxWindow passes the project's configured path, preventing arbitrary dir access. 2. DRY: Extract boolToInt() helper for bool→int SQLite conversion, removing duplication in CreateProject/UpdateProject. 3. Cleanup: Remove duplicate doc comment on isValidWorktreePath. 4. Tests: Add TestProjectUsesWorktrees (config), alias-based lookup with UseWorktrees flag (db), TestSpotlightRejectsNonWorktreeProject (mcp), and improved TestIsValidWorkDir with security assertions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #484 addressing code review findings:
isValidWorkDirnow requires an explicitallowedProjectDirparameter — only the project's configured path is accepted for non-worktree projects, not any arbitrary directoryboolToInt()helper to eliminate bool→int conversion duplicationisValidWorktreePathisValidWorkDirsecurity assertionsTest plan
TestProjectUsesWorktrees(config) — tests empty, unknown, enabled, and disabled projectsUseWorktreesflag (db) — verifies flag preserved through alias resolutionTestSpotlightRejectsNonWorktreeProject(mcp) — verifies clear error messageTestIsValidWorkDir— verifies path-matching security and rejects mismatched/arbitrary paths🤖 Generated with Claude Code