Fix kanban columns to display more tasks (v2)#88
Merged
Conversation
The cardHeight was set to 4 in View() and ensureSelectedVisible(), but task cards are actually 3 lines (2 content + 1 border) for non-selected cards. This caused ~25% fewer tasks to be displayed than could fit. Changed cardHeight from 4 to 3 to match the actual card rendering and the existing HandleClick() code which already used 3. This is a minimal fix that only changes the maxTasks calculation without modifying colHeight or other layout properties. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cardHeightfrom 4 to 3 inView()andensureSelectedVisible()HandleClick()code which already usedtaskCardHeight := 3What's different from the reverted PR
This is a minimal fix that only changes the
cardHeightconstant. The previous PR modifiedcolHeightwhich affected the column box dimensions and broke the headers. This PR does not touchcolHeightat all.Expected result
~33% more tasks displayed per column without affecting the column header layout.
Test plan
go test ./internal/ui/...- all tests passgo build ./...- builds successfully🤖 Generated with Claude Code