feat: add confirmation dialog to task kill command#96
Merged
Conversation
- Add ViewKillConfirm view state and Kill key binding (k) - Show confirmation dialog before killing a task session - On kill confirmation: interrupt task (set status to backlog), log the kill action, and terminate the tmux window - Clean up detail view panes before executing kill - Remove direct k key handling from detail.go (now handled at app level) The kill command now properly stops the Claude process and updates the task status, rather than just closing the tmux window UI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
35d23dc to
d009015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kin detail view)Changes
ViewKillConfirmview state andKillkey binding (k)showKillConfirm,viewKillConfirm,updateKillConfirmfunctions for confirmation flowkillTaskfunction that interrupts the task and kills the tmux windowtaskKilledMsgmessage type for handling kill completionkkey handling fromdetail.go(now handled at app level with confirmation)Test plan
kin detail view - should show kill confirmation dialogkagain and confirm - should kill session and move task to backlog🤖 Generated with Claude Code