feat: improve toast UX#165
Merged
Merged
Conversation
… IDs for better status management.
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Walkthrough该PR在播放列表同步功能中实现了持久化的toast通知系统。修改涉及多个同步端点（本地、收藏、多页面）添加带ID的持久toast，通过mutation传递toastId以关联toast生命周期，并更新toast工具函数返回值以支持后续的dismiss操作。 Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant UI as 播放列表页面
participant Toast as Toast系统
participant Mutation as Sync Mutation
participant API as 后端API
User->>UI: 点击同步按钮
activate UI
UI->>Toast: toast.show('同步中...', {id: 'sync-playlist', duration: Infinity})
activate Toast
Toast-->>UI: 返回 toastId
deactivate Toast
UI->>Mutation: mutate({remoteSyncId, type, toastId: 'sync-playlist'})
deactivate UI
activate Mutation
Mutation->>API: 发起同步请求
activate API
alt 同步成功
API-->>Mutation: 返回成功结果
Mutation->>Toast: toast.success(..., {id: 'sync-playlist'})
activate Toast
Toast->>Toast: 替换toast为成功状态
deactivate Toast
Mutation->>UI: 导航到本地播放列表
else 同步失败
API-->>Mutation: 返回错误
Mutation->>Toast: toast.dismiss('sync-playlist')
activate Toast
Toast->>Toast: 关闭loading toast
deactivate Toast
Mutation->>Mutation: 记录错误日志
end
deactivate API
deactivate Mutation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/app/playlist/remote/favorite/[id].tsx (1)
85-110:setRefreshing(false)执行时机错误导致刷新状态无效。
setRefreshing(false)在 Line 109 同步调用，但syncFavorite是异步操作。这意味着refreshing状态几乎立即被设为false，使得刷新指示器无法正确反映同步进度。🔧 建议的修复方案
const handleSync = useCallback(() => { if (favoriteData?.pages.flatMap((page) => page.medias).length === 0) { toast.info('收藏夹为空，无需同步') return } const toastId = 'sync-playlist' toast.show('同步中...', { id: toastId, duration: Infinity }) setRefreshing(true) syncFavorite( { remoteSyncId: Number(id), type: 'favorite', toastId, }, { onSuccess: (id) => { + setRefreshing(false) if (!id) return router.replace({ pathname: '/playlist/local/[id]', params: { id: String(id) }, }) }, + onError: () => { + setRefreshing(false) + }, }, ) - setRefreshing(false) }, [favoriteData?.pages, id, router, syncFavorite])或者使用
onSettled回调统一处理：syncFavorite( { ... }, { onSuccess: (id) => { ... }, + onSettled: () => { + setRefreshing(false) + }, }, ) - setRefreshing(false)src/app/playlist/remote/collection/[id].tsx (1)
78-99:setRefreshing(false)执行时机错误。与
favorite/[id].tsx存在相同问题：setRefreshing(false)在 Line 98 同步调用，而非等待异步 mutation 完成。🔧 建议的修复方案
const handleSync = useCallback(() => { const toastId = 'sync-playlist' toast.show('同步中...', { id: toastId, duration: Infinity }) setRefreshing(true) syncCollection( { remoteSyncId: Number(id), type: 'collection', toastId, }, { onSuccess: (id) => { + setRefreshing(false) if (!id) return router.replace({ pathname: '/playlist/local/[id]', params: { id: String(id) }, }) }, + onSettled: () => { + setRefreshing(false) + }, }, ) - setRefreshing(false) }, [id, router, syncCollection])src/app/playlist/remote/multipage/[bvid].tsx (1)
101-122:setRefreshing(false)执行时机错误。与
favorite/[id].tsx和collection/[id].tsx存在相同问题。建议统一修复所有三个文件的handleSync回调。🔧 建议的修复方案
const handleSync = useCallback(() => { const toastId = 'sync-playlist' toast.show('同步中...', { id: toastId, duration: Infinity }) setRefreshing(true) syncMultipage( { remoteSyncId: bv2av(bvid), type: 'multi_page', toastId, }, { onSuccess: (id) => { + setRefreshing(false) if (!id) return router.replace({ pathname: '/playlist/local/[id]', params: { id: String(id) }, }) }, + onSettled: () => { + setRefreshing(false) + }, }, ) - setRefreshing(false) }, [bvid, router, syncMultipage])
Collaborator
Author
|
/build-nightly |
Contributor
⏹️ Nightly 构建已取消构建被新的
|
Collaborator
Author
|
/build-nightly |
Contributor
✅ Nightly 构建成功
APK 已上传到 Nightly Release 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… IDs for better status management.
Summary by CodeRabbit
发布说明
✏️ Tip: You can customize this high-level summary in your review settings.