Eliminate shell/Python duplication in entrypoint and proxy scripts#143
Merged
Eliminate shell/Python duplication in entrypoint and proxy scripts#143
Conversation
Move sandbox config generation and domain ACL formatting from shell
to Python, removing ~250 lines of duplicated bash logic. Split the
main entrypoint (508 → 169 lines) into sourced libraries for
maintainability.
Key changes:
- Activate Python-generated sandbox config scripts via both backends,
removing the 117-line bash fallback in entrypoint-session.sh
- Add format_domains_as_squid_acls() to domains.py, passing
pre-formatted ACLs to the proxy container (62 vs 121 lines)
- Split entrypoint-session.sh into entrypoint-lib-{config,credentials,
install}.sh sourced libraries
- Fix minor shell anti-patterns (basename→parameter expansion,
cat→$(<), redundant chmod consolidation)
- Fix Cursor sandbox config ws_slug parameter expansion (assign
workspace to local variable before bash string replacement)
- Add fallback dstdomain ACL when only regex domains are present
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move sandbox config generation and domain ACL formatting from shell
to Python, removing ~250 lines of duplicated bash logic. Split the
main entrypoint (508 → 169 lines) into sourced libraries for
maintainability.
Key changes:
removing the 117-line bash fallback in entrypoint-session.sh
pre-formatted ACLs to the proxy container (62 vs 121 lines)
install}.sh sourced libraries
cat→$(<), redundant chmod consolidation)
workspace to local variable before bash string replacement)
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com