fix(challenges): défi à franchissements gorge ne se termine jamais#295
Merged
bbstudioapp merged 1 commit intoMay 30, 2026
Merged
Conversation
Les axes gorgeCrossingsBpm{Throat,Full} n'avaient pas de cas dans
_fromOf/_toOf → ch.to == null. Le contrôleur incrémente le compteur de
franchissements sur e.to == ch.to ; avec ch.to null le compteur reste
figé à 0, la condition de fin (count >= targetCrossings) n'est jamais
atteinte et le builder émet des segments indéfiniment → boucle infinie.
Ajoute head→throat (throat) et mid→full (full), alignés sur les jumeaux
rhythmBpmCeil{Throat,Full} qui fonctionnent et sur les pools des builders.
Régression couverte dans challenge_service_test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Les axes gorgeCrossingsBpm{Throat,Full} n'avaient pas de cas dans _fromOf/_toOf → ch.to == null. Le contrôleur incrémente le compteur de franchissements sur e.to == ch.to ; avec ch.to null le compteur reste figé à 0, la condition de fin (count >= targetCrossings) n'est jamais atteinte et le builder émet des segments indéfiniment → boucle infinie.
Ajoute head→throat (throat) et mid→full (full), alignés sur les jumeaux rhythmBpmCeil{Throat,Full} qui fonctionnent et sur les pools des builders. Régression couverte dans challenge_service_test.