Closed
Conversation
This was referenced May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements two minor improvements in
did:1. Handling Missing Never-Treated Groups:
When no never-treated group is available in data and the user impose "nevertreated" as control group,
didnow issues a warning instead of throwing an error. In this scenario, the last treated cohort (as defined by gname) is used as a "synthetic" never-treated group. We drop all the data from periods>= max_g. This is working with regular and faster mode.2. Suppressing Warnings for Unbalanced Panels/RCS:
To resolve weird warnings that occur with unbalanced panels or repeated cross-sections, I've added a
fill=TRUEargument when constructing the influence function matrix.