JSSE: Persist handshake session application data to final session#2137
Closed
steffen-heil-secforge wants to merge 1 commit intobcgit:mainfrom
Closed
Conversation
This change makes BC JSSE consistent with Oracle JSSE by copying application data stored via putValue() in the handshake session to the final session after handshake completion. Previously, data stored during certificate verification (e.g., in custom TrustManager implementations) would be lost when transitioning from handshake session to final session. Changes: - Copy application data in notifyHandshakeComplete() methods - Add test case to verify data persistence - Maintain backward compatibility Fixes: bcgit#2136 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
As discussed in #2136, this PR has been superceded by changes that allow the session bindings to be shared across the session lifecycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes BC JSSE consistent with Oracle JSSE by copying application data stored via
putValue()in the handshake session to the final session after handshake completion.Problem
Previously, data stored during certificate verification (e.g., in custom TrustManager implementations) would be lost when transitioning from handshake session to final session. This created inconsistent behavior compared to Oracle JSSE and broke common use cases.
Test Results
Before fix:
BCJSSE: value available: false(data lost)SunJSSE: value available: true(data persists)After fix:
BCJSSE: value available: true(data now persists)SunJSSE: value available: true(unchanged)Changes Made
notifyHandshakeComplete()notifyHandshakeComplete()notifyHandshakeComplete()Code Changes
Added these 4 lines to each
notifyHandshakeComplete()method:Compatibility
Use Cases Enabled
Fixes #2136