Blake2bDigest: defensive improvements and cleanup#2205
Closed
lomigmegard wants to merge 1 commit intobcgit:mainfrom
Closed
Blake2bDigest: defensive improvements and cleanup#2205lomigmegard wants to merge 1 commit intobcgit:mainfrom
lomigmegard wants to merge 1 commit intobcgit:mainfrom
Conversation
Defensive changes: - Validate key length before copying to fail fast and avoid unnecessary allocation on invalid input - Add null check before zeroing chainValue in reset() - Centralize state cleanup in reset() to avoid double-zeroing and ensure consistent cleanup path Code quality: - Use explicit 64-bit literals for long fields (f1) for clarity - Add final modifier to ROUNDS constant - Remove redundant return statement Minor fixes: - Fix typo in Javadoc (Blakbe2b -> Blake2b) - Use more efficient Pack.longToLittleEndian overload for partial digest output, avoiding intermediate byte[] allocation
Collaborator
|
Merged, thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at
Blake2bDigestimplementation I noticed a few things that could be tidied up.Defensive changes:
Code quality:
f1for clarity. I initially thought it was a bug, but Java bit extension makes the current syntax correct but misleading.LLM disclaimer: