Skip to content

Test: Add an invalid page number to trigger failure of validation pipeline#6

Merged
SteveF4 merged 2 commits intodevelopfrom
fix/stephen-test-feature-branch
Sep 11, 2025
Merged

Test: Add an invalid page number to trigger failure of validation pipeline#6
SteveF4 merged 2 commits intodevelopfrom
fix/stephen-test-feature-branch

Conversation

@SteveF4
Copy link
Copy Markdown
Contributor

@SteveF4 SteveF4 commented Sep 11, 2025

This commit intentionally introduces an invalid page number value to test the validation pipeline and demonstrate how the CI/CD process catches schema violations in BuildingCode.json.

Before committing this change, ran ran validation against the schema locally, and it failed because a page number is not an integer:

PS> check-jsonschema --schemafile .\schema.json .\BuildingCode.json
Schema validation errors were encountered.
  .\BuildingCode.json::$.divisionA[0].page: 'This page number is invalid and this PR will be blocked by pipeline validity checks.' is not of type 'integer'

This should be detected by the GitHub pipeline and this PR blocked until it is fixed.

This commit intentionally introduces an invalid page number value to test
the validation pipeline and demonstrate how the CI/CD process catches
schema violations in BuildingCode.json.
@github-actions
Copy link
Copy Markdown

❌ JSON Schema Validation Failed

The BuildingCode.json file does not conform to the schema. Please fix the following errors before merging:

Found 1 validation error(s):

Error #1:
System ID: /home/runner/work/BC-Building-Code/BC-Building-Code/BuildingCode.json
Main validation file: /home/runner/work/BC-Building-Code/BC-Building-Code/BuildingCode.json
Schema: /home/runner/work/BC-Building-Code/BC-Building-Code/schema.json
Engine name: JSON Validator
Severity: error
Description: #/divisionA/0/page: string [This page number is invalid and this PR will be...] is not of type integer
Path: divisionA -> 0 -> page

This PR cannot be merged until all validation errors are resolved.

@SteveF4
Copy link
Copy Markdown
Contributor Author

SteveF4 commented Sep 11, 2025

Excellent. The commit was blocked. Now I will change the JSON to pass validation, and the commit should be approved and merged into the develop branch.

- Changed page number from invalid string to integer 12345
- JSON now passes schema validation
- Resolves validation pipeline failure
@github-actions
Copy link
Copy Markdown

✅ JSON Schema Validation Passed

The BuildingCode.json file successfully validates against the schema. This PR is ready for review.

@SteveF4 SteveF4 merged commit 1c5cd03 into develop Sep 11, 2025
1 check passed
@SteveF4 SteveF4 deleted the fix/stephen-test-feature-branch branch September 11, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant