Reinstating Deployment (replacement of DeploymentConfig)#146
Merged
rogene-bcgov merged 1 commit intodevelopfrom May 9, 2025
Merged
Reinstating Deployment (replacement of DeploymentConfig)#146rogene-bcgov merged 1 commit intodevelopfrom
rogene-bcgov merged 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the deprecated DeploymentConfig with the Deployment resource for both client and API components, reinstating deployment support while updating related configurations.
- Update API version and kind from v1/DeploymentConfig to apps/v1/Deployment
- Adjust label selectors and template labels to use "deployment" instead of "deploymentconfig"
- Update image references and add a new NAMESPACE parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openshift/client-deploy-config.yml | Replaces DeploymentConfig with Deployment; updates selectors and image path; comments out resource and trigger blocks. |
| openshift/api-deploy-config.yml | Similar changes for API deployment, including a change to a more explicit rolling update strategy and updated selectors. |
Comments suppressed due to low confidence (2)
openshift/client-deploy-config.yml:28
- [nitpick] Consider using a more descriptive label name than 'deployment' to clearly distinguish this selector if similar labels are used elsewhere.
deployment: ${NAME}${SUFFIX}
openshift/api-deploy-config.yml:28
- [nitpick] Consider using a more specific label name than 'deployment' to avoid potential ambiguity in multi-deployment environments.
deployment: ${NAME}${SUFFIX}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinstating Deployment (replacement of DeploymentConfig)