Skip to content

Reinstating Deployment (replacement of DeploymentConfig)#146

Merged
rogene-bcgov merged 1 commit intodevelopfrom
GRANT-671-Deployment-Configs-Improvements
May 9, 2025
Merged

Reinstating Deployment (replacement of DeploymentConfig)#146
rogene-bcgov merged 1 commit intodevelopfrom
GRANT-671-Deployment-Configs-Improvements

Conversation

@rogene-bcgov
Copy link
Collaborator

Reinstating Deployment (replacement of DeploymentConfig)

@rogene-bcgov rogene-bcgov requested a review from Copilot May 9, 2025 21:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the deprecated DeploymentConfig with the Deployment resource for both client and API components, reinstating deployment support while updating related configurations.

  • Update API version and kind from v1/DeploymentConfig to apps/v1/Deployment
  • Adjust label selectors and template labels to use "deployment" instead of "deploymentconfig"
  • Update image references and add a new NAMESPACE parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
openshift/client-deploy-config.yml Replaces DeploymentConfig with Deployment; updates selectors and image path; comments out resource and trigger blocks.
openshift/api-deploy-config.yml Similar changes for API deployment, including a change to a more explicit rolling update strategy and updated selectors.
Comments suppressed due to low confidence (2)

openshift/client-deploy-config.yml:28

  • [nitpick] Consider using a more descriptive label name than 'deployment' to clearly distinguish this selector if similar labels are used elsewhere.
          deployment: ${NAME}${SUFFIX}

openshift/api-deploy-config.yml:28

  • [nitpick] Consider using a more specific label name than 'deployment' to avoid potential ambiguity in multi-deployment environments.
          deployment: ${NAME}${SUFFIX}

@rogene-bcgov rogene-bcgov merged commit 096f9d3 into develop May 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants