Grant 665 match numbering on infrastructure form#151
Merged
gurpreetsingh9-ey merged 3 commits intodevelopfrom May 15, 2025
Merged
Grant 665 match numbering on infrastructure form#151gurpreetsingh9-ey merged 3 commits intodevelopfrom
gurpreetsingh9-ey merged 3 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the numbering mismatch for Infrastructure type review questions and improves label rendering for content-type form elements. Key changes include:
- Updating question numbering in the review constants.
- Adding a new helper function renderGeneralLabel to display labels for form elements of type content.
- Adjusting corresponding question labels and descriptions in the constants file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| client/helpers/render-elements.helpers.tsx | Added renderGeneralLabel and updated renderElementType to support content |
| client/constants/review-constants.ts | Updated numbering and question labels to match the latest form version |
Collaborator
rogene-bcgov
left a comment
There was a problem hiding this comment.
I'm good with these but please consider what Copilot suggested 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Changes:
renderGeneralLabelto display labels forcontenttype form elementsReferences:
Screenshots:
B.C. - Programs Branch Grant Programs.pdf
applicable)
Safety