Skip to content

Grant 665 match numbering on infrastructure form#151

Merged
gurpreetsingh9-ey merged 3 commits intodevelopfrom
GRANT-665-match-numbering-on-infrastructure-form
May 15, 2025
Merged

Grant 665 match numbering on infrastructure form#151
gurpreetsingh9-ey merged 3 commits intodevelopfrom
GRANT-665-match-numbering-on-infrastructure-form

Conversation

@gurpreetsingh9-ey
Copy link
Contributor

Resolves:

  • It resolves the numbering mismatch for Infrastructure type review questions

Changes:

  • updated numbering according to latest forms
  • added a renderGeneralLabel to display labels for content type form elements

References:

Screenshots:

Safety

  • steps taken to ensure no breaking changes are introduced (eg. testing).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the numbering mismatch for Infrastructure type review questions and improves label rendering for content-type form elements. Key changes include:

  • Updating question numbering in the review constants.
  • Adding a new helper function renderGeneralLabel to display labels for form elements of type content.
  • Adjusting corresponding question labels and descriptions in the constants file.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
client/helpers/render-elements.helpers.tsx Added renderGeneralLabel and updated renderElementType to support content
client/constants/review-constants.ts Updated numbering and question labels to match the latest form version

Copy link
Collaborator

@rogene-bcgov rogene-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these but please consider what Copilot suggested 😄

@gurpreetsingh9-ey gurpreetsingh9-ey merged commit 4aa4836 into develop May 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants