Ado 3265 omit fields from xml#103
Merged
Merged
Conversation
…to ADO-3265-omit-fields-from-xml
bzimonjaSDPR
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Wrapped JSON -> XML fixes code in a check that only adds value to final JSON -> XML if the field is not in the dictionary's omit fields. For forms not in dictionary, the omit list should be empty so everything passes.
This omit works for normal (highest level and their children) and list-children values in JSON.
Why did you make these changes?
Some forms do not require every JSON property to be added to XML. Using the dictionary, this allows us to omit fields that would normally otherwise appear in the XML format.
What alternatives did you consider?
Moving the omit checks to the "push" areas of the code. This would stop the omit field from being added, however that would mean "fixes" were applied for no reason. By moving the omit check around the bulk of the code, this stops it from proceeding with the "fixes" and stops it from adding the field to the JSON -> XML
Checklist