Skip to content

Ado 3265 omit fields from xml#103

Merged
bzimonjaSDPR merged 3 commits into
devfrom
ADO-3265-omit-fields-from-xml
Sep 8, 2025
Merged

Ado 3265 omit fields from xml#103
bzimonjaSDPR merged 3 commits into
devfrom
ADO-3265-omit-fields-from-xml

Conversation

@NicolaSDPR1
Copy link
Copy Markdown
Collaborator

What changes did you make?

Wrapped JSON -> XML fixes code in a check that only adds value to final JSON -> XML if the field is not in the dictionary's omit fields. For forms not in dictionary, the omit list should be empty so everything passes.

This omit works for normal (highest level and their children) and list-children values in JSON.

Why did you make these changes?

Some forms do not require every JSON property to be added to XML. Using the dictionary, this allows us to omit fields that would normally otherwise appear in the XML format.

What alternatives did you consider?

Moving the omit checks to the "push" areas of the code. This would stop the omit field from being added, however that would mean "fixes" were applied for no reason. By moving the omit check around the bulk of the code, this stops it from proceeding with the "fixes" and stops it from adding the field to the JSON -> XML

Checklist

  • I have assigned at least one reviewer
  • My code meets the style guide
  • My code has adequate test coverage (if applicable)

@bzimonjaSDPR bzimonjaSDPR merged commit 0eb7712 into dev Sep 8, 2025
3 checks passed
@bzimonjaSDPR bzimonjaSDPR deleted the ADO-3265-omit-fields-from-xml branch September 8, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants