(ADO-3390) addFields applied to dictionary and XML#113
Merged
Conversation
bzimonjaSDPR
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Dictionary now supports addFields. This means empty fields can now be added to the JSON in order to appear in the XML after conversion.
Fix where Kiln version was only giving results in XML for V2 instead of both v1 and v2.
CF2900 has wrapper tags and add fields applied to it in dictionary.
Why did you make these changes?
Some forms require the XML to include empty field tags. In order to do this, the JSON needs to have required key-value pairs as "field name": null. This update fulfils this requirement for up to 6 levels deep into an object's key-value pairs.
CF2900 was done to assist with testing the XML.
What alternatives did you consider?
The solution for this has the potential to work as a recursive function. It remains up to 6-levels rather than be made recursive in order to start testing for additional values.
NOTE: licensed-group-b650d0a6-2871-433c-9a2b-9e80a2f7c9a8 appears twice in CF2900 wrapper tags. It will display as the second one in XML (i.e. the key-pair with value 2).
Checklist