Extend automatic form generation endpoint with sanity checks#73
Merged
Conversation
Updating main branch
Updating Main Branch with Test
Updating test branch with dev
Updating Prod branch with test
Update test branch
Update main branch
danilomeireles
commented
Aug 1, 2025
bzimonjaSDPR
requested changes
Aug 6, 2025
Collaborator
bzimonjaSDPR
left a comment
There was a problem hiding this comment.
Please check into dev first. We don't use main.
bzimonjaSDPR
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Added three new validation checks to the generateNewTemplate function to ensure data integrity and prevent mismatched form generation:
Template ID validation: Verify that the requested template_id matches the template stored in ICM metadata
Tool validation: Ensure the ICM metadata indicates "formfoundry" as the designated tool (case-insensitive)
Area validation: Validate that the request area parameter matches the ICM category when an area is specified (case-insensitive, optional)
Why did you make these changes?
These validations prevent potential issues:
What alternatives did you consider?
No other alternatives were considered as this endpoint is the right place for these validations.
Checklist