Skip to content

ADO-3273#92

Merged
bzimonjaSDPR merged 1 commit into
devfrom
ADO-3273
Aug 28, 2025
Merged

ADO-3273#92
bzimonjaSDPR merged 1 commit into
devfrom
ADO-3273

Conversation

@NicolaSDPR1
Copy link
Copy Markdown
Collaborator

What changes did you make?

  • Moved the gathering of form field ids to a function at the bottom of the page. Included into it the storing of checkbox field ids.
  • Created a function at the bottom of the page to change true/false/(null/undefined) into Yes/No/""
  • Applied the change function to any fields that match the checkbox ids gathered and put the fields with Yes/No/"" into the json that will be converted to XML

Why did you make these changes?

The checkbox values in the JSON checkbox fields need to be Yes/No/"" in order for the XML it converts to, to pass when saving.

What alternatives did you consider?

I considered making the getFormIds function into a recursive one so that there was less code and no need for manual updates if containers can go deeper than five levels. I have put off making that for now to save time for this fix. May want to consider turning the function into a recursive one in the future.

Checklist

  • I have assigned at least one reviewer
  • My code meets the style guide
  • My code has adequate test coverage (if applicable)

@bzimonjaSDPR bzimonjaSDPR merged commit ddfc0a2 into dev Aug 28, 2025
3 checks passed
@bzimonjaSDPR bzimonjaSDPR deleted the ADO-3273 branch August 28, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants