Skip to content

Ado 3265 wrapping tags#96

Merged
DavidOkulski merged 4 commits into
devfrom
ADO-3265-wrapping-tags
Sep 3, 2025
Merged

Ado 3265 wrapping tags#96
DavidOkulski merged 4 commits into
devfrom
ADO-3265-wrapping-tags

Conversation

@NicolaSDPR1
Copy link
Copy Markdown
Collaborator

What changes did you make?

  • Fixed function descriptions for dictionary utils
  • Fixed is empty checks in dictionary utils
  • Added values to form dictionary for wrapping tags
  • Added wrapper capability to saveICMdataHandler.js
  • Moved majority of JSON readying for XML code to its own function for clearer readability

Why did you make these changes?

  • Function descriptions are now visible when hovering over a function in another file.
  • Empty checks need to be able to see if an array or object is empty.
  • The wrapping tag includes the name of the tag to be the wrapper (the key) and a list of the UUIDs for the form that will be wrapped in it (the object/list of ids). Using this wrapper will solve the issue of UUIDs being required to group for certain wrappers/parent tags.
  • The changes for configuring JSON values to meet standards when they transform to XML was getting very long. Moving it to its own function keeps it all in one place and allows the saveICMdata to be more readable.

What alternatives did you consider?

I considered using a list of objects to contain wrapper name and wrapper UUIDs required in one object rather than having the name be the key. However, the current format is a lot easier to read in the dictionary and pair up full UUIDs to be wrapped when sorting through the configurations for JSON to XML changes.

Checklist

  • I have assigned at least one reviewer
  • My code meets the style guide
  • My code has adequate test coverage (if applicable)

@DavidOkulski DavidOkulski merged commit b81d463 into dev Sep 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants