Conversation
Collaborator
|
This needs a detailed review/testing pass |
wmuldergov
force-pushed
the
task/DBC22-5355
branch
from
543c15f to
641edb1
Compare
ray-oxd
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few API's that had redis caching enabled, but a lot did not.
To improve backend performance and reduce load on the DB I added caching to the public API's so that we have significantly less hits on the DB. The ticket has a performance comparison, but most are 90%+ faster when it comes from the cache vs from the DB.
Most caches are cleared when the job runs, but for ones that aren't (ie for CMS API's) they have a short TTL to ensure they don't get too stale.
Take a look at the enums file and see if the values are reasonable.