Skip to content

update filter by staff id to check for epd as well#1965

Merged
dinesh-aot merged 3 commits intobcgov:developfrom
jadmnsaad:TRACK-task#1902
Mar 12, 2024
Merged

update filter by staff id to check for epd as well#1965
dinesh-aot merged 3 commits intobcgov:developfrom
jadmnsaad:TRACK-task#1902

Conversation

@jadmnsaad
Copy link
Contributor

@jadmnsaad jadmnsaad commented Mar 8, 2024

https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1902
https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/1865

Details:

  • update filter by staff to check if staff id matches responsible epd id as well
  • Update filter by staff to filter for active team members only

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@d0779d8). Click here to learn what that means.

Files Patch % Lines
epictrack-api/src/api/models/work.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1965   +/-   ##
==========================================
  Coverage           ?   76.11%           
==========================================
  Files              ?      283           
  Lines              ?     9198           
  Branches           ?        0           
==========================================
  Hits               ?     7001           
  Misses             ?     2197           
  Partials           ?        0           
Flag Coverage Δ
epictrack-api 76.11% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jadmnsaad jadmnsaad requested a review from dinesh-aot March 11, 2024 18:18
@dinesh-aot dinesh-aot merged commit 9b9ba76 into bcgov:develop Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants