Skip to content

UAT Release - IS76#3907

Merged
asanchezr merged 77 commits intobcgov:testfrom
asanchezr:release/uat_is76
Mar 28, 2024
Merged

UAT Release - IS76#3907
asanchezr merged 77 commits intobcgov:testfrom
asanchezr:release/uat_is76

Conversation

@asanchezr
Copy link
Collaborator

No description provided.

devinleighsmith and others added 30 commits March 14, 2024 00:01
* psp-8009 update default login screen to display moti details.

* snapshot updates.

---------

Co-authored-by: Smith <devin.smith@quartech.com>
* test corrections - updates to remove all console warnings.

* additional updates.

* lint corrections. case correction.
* Fixed consolidation and subdivision tests

* Lint fixes

* removed log
* psp-7875 update pims error handling to prevent bomb from being shown when error handled.

* test corrections.
bcgov#3854)

Co-authored-by: Herrera <eduardo.herrera@quartech.com>
devinleighsmith and others added 21 commits March 25, 2024 15:57
bcgov#3894)

* psp-7962 correct missing no rows message introduced by operation section subtable.

* snapshot update.

* test corrections.

---------

Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
* Research files also match retired properties now

* Updated tests
Co-authored-by: Manuel Rodriguez <marobej@gmail.com>
… property. (bcgov#3903)

Co-authored-by: Herrera <eduardo.herrera@quartech.com>
* PSP-8144 Fix file closing logic

* PSP-8119 Fix NPE when adding existing properties to a disposition file

* Fix invalid logic for MatchProperties by PIN
Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 76.78208% with 114 lines in your changes are missing coverage. Please review.

Project coverage is 75.28%. Comparing base (4032f54) to head (43b6338).
Report is 103 commits behind head on test.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             test    #3907      +/-   ##
==========================================
- Coverage   75.30%   75.28%   -0.02%     
==========================================
  Files        1440     1441       +1     
  Lines       39529    39757     +228     
  Branches     8120     8196      +76     
==========================================
+ Hits        29767    29931     +164     
- Misses       9461     9524      +63     
- Partials      301      302       +1     
Flag Coverage Δ
unittests 75.28% <76.78%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/backend/api/Services/DocumentService.cs 96.61% <ø> (ø)
source/backend/api/Services/ResearchFileService.cs 57.72% <100.00%> (ø)
...s/Concepts/ResearchFile/ResearchFilePropertyMap.cs 100.00% <100.00%> (ø)
...ckend/dal/Helpers/Extensions/PropertyExtensions.cs 94.66% <100.00%> (ø)
.../Repositories/AcquisitionFilePropertyRepository.cs 98.07% <100.00%> (+0.11%) ⬆️
...kend/dal/Repositories/AcquisitionFileRepository.cs 92.23% <100.00%> (+0.03%) ⬆️
.../Repositories/DispositionFilePropertyRepository.cs 98.00% <100.00%> (+0.12%) ⬆️
...kend/dal/Repositories/DispositionFileRepository.cs 92.08% <100.00%> (+0.04%) ⬆️
source/backend/dal/Repositories/LeaseRepository.cs 97.67% <100.00%> (+<0.01%) ⬆️
...rce/backend/dal/Repositories/PropertyRepository.cs 88.91% <100.00%> (+0.75%) ⬆️
... and 86 more

... and 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants