PSP-8880: Add Payee tab to Payable leases#4258
Conversation
…r Stakeholder Types
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
|
||
| namespace Pims.Api.Models.Concepts.Lease | ||
| { | ||
| public class LeaseStakeholderTypeModel : BaseConcurrentModel |
There was a problem hiding this comment.
This should almost certainly inherit from CodeTypeModel.
| Cell: (props: CellProps<FormTenant>) => { | ||
| const original = props.row.original; | ||
| const status = | ||
| original.original !== undefined |
There was a problem hiding this comment.
original.original is quite hard to read, can you clean this up a bit? Please also break this out so its not just one giant nested ternary.
| key: LeaseFileTabNames.tenant, | ||
| name: 'Tenant', | ||
| }); | ||
| if (lease?.paymentReceivableType.id === 'RCVBL') { |
There was a problem hiding this comment.
could this be refactored to just change the name of the tabview instead of having these two if statements?
devinleighsmith
left a comment
devinleighsmith
left a comment
There was a problem hiding this comment.
Please address comments.
2 participants
No description provided.