re-enable codecov, and sonarqube on the frontend.#4296
Merged
devinleighsmith merged 7 commits intobcgov:devfrom Sep 15, 2024
Merged
re-enable codecov, and sonarqube on the frontend.#4296devinleighsmith merged 7 commits intobcgov:devfrom
devinleighsmith merged 7 commits intobcgov:devfrom
Conversation
devinleighsmith
commented
Aug 28, 2024
| - name: SonarQube Scan | ||
| id: scan | ||
| uses: sonarsource/sonarqube-scan-action@master | ||
| if: false |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure why this was disabled - the quality gate / upload pass on my fork.
devinleighsmith
commented
Aug 28, 2024
| uses: codecov/codecov-action@v3.1.1 | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV }} | ||
| - name: Save PR number and scan results |
Collaborator
Author
There was a problem hiding this comment.
upload test results for consumption by codecov.
devinleighsmith
commented
Aug 28, 2024
| run_id: ${{github.event.workflow_run.id }}, | ||
| }); | ||
| var matchArtifact = artifacts.data.artifacts.filter((artifact) => { | ||
| return artifact.name == "pr-codecov" |
Collaborator
Author
There was a problem hiding this comment.
pull the named artifact.
devinleighsmith
commented
Aug 28, 2024
| env_vars: C# | ||
| # Specify whether or not CI build should fail if Codecov runs into an error during upload | ||
| fail_ci_if_error: false | ||
| override_pr: ${{steps.create-comment.outputs.result}} |
Collaborator
Author
There was a problem hiding this comment.
Need to provide the PR, as this workflow does not have direct access to the PR.
devinleighsmith
commented
Aug 28, 2024
| # access to secrets | ||
| on: | ||
| workflow_run: | ||
| workflows: ["API (.NET 8)", "APP (React)"] |
Collaborator
Author
There was a problem hiding this comment.
Kicked off by the completion of one of these two.
devinleighsmith
commented
Aug 28, 2024
| return issue_number; | ||
| result-encoding: string | ||
| - name: Codecov(API) | ||
| if: ${{ github.event.workflow_run.name == 'API (.NET 8)' }} |
Collaborator
Author
There was a problem hiding this comment.
slightly different params for the two different workflows.
Collaborator
Author
|
Tested this on my fork, doesn't provide the nice visual that codecov used to with this format, can figure that out later. |
Contributor
|
✅ No secrets were detected in the code. |
FuriousLlama
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.