PSP-10572 ensure that the file property is set on the passed fileProp…#4889
Merged
PSP-10572 ensure that the file property is set on the passed fileProp…#4889
Conversation
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4889 |
asanchezr
approved these changes
Jul 7, 2025
|
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4889 |
devinleighsmith
added a commit
that referenced
this pull request
Jul 10, 2025
* psp-10371 allow file properties to be disabled. create a system generated note when a property is disabled. display a different marker for disabled properties. * ensure that clicking on a property selects the correct entry in the file. * PSP-10592 : FT-REG: Error 400 thrown when an Activity from a Management file is deleted (#4857) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.11.0-105.14 * PSP-10580: Updates on test cases IS105 (#4858) * Changes on automation branch * Changes on existing automated test based on last changes from IS98 * Update Acquisition Details file * Implementation of automated reports * Update BrowserDriver and PageObjectBase * integration test changes to implement extent reports * Applying changes for Extent report to work on github actions * Deleting v2 artifact command * integration test changes to implement extent reports * Changing Firefox driver location * Moving geckodriver to readeable path * Extent report implementation * integration test changes * reports last step from workflow * Correcting folder * Changes on extent report config * Changes on Extent report config * uploading report example * Changes on automation set to accomodate data on DEV environment * Adding SSH to avoid errors * Changes integration-test.yml * Changing extent report folder name * Chnages on extent report folder name * Changing directory of the report for github actions * Adding creating a folder for reports on github actions * integration-test.yml changes * Changing extent reports folder * generate report fix * Changes to generate images on github actions report * Changes on report * Delete testing/PIMS.Tests.Automation/Reports/Extent_Reports/PIMS_AutomationReport.html * Changes IS100 automation test set * Changes on IS100 automation * Automation test set changes IS101 * Changes on Consolidation * Properties Test cases * Lease Active indicator test cases * Adding filters and map layers verification of elements * Automation IS102 changes * Automation IS103 changes * Management new feature * Adding Management Steps and Feature * Management Files And Lease Teams * Delete sql queries for testing * Automation - adding default province name test * Automated tests - IS105 * Management File and Property Management Tab Activities * Update on Regression test cases IS105 --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-105.15 * Bump version - 106 (#4861) * CI: Bump version to v5.11.0-106.1 * Merge pull request #4847 from FuriousLlama/features/psp-10341 psp-10341 | Layers Menu refactor * CI: Bump version to v5.11.0-106.2 * PSP-10589 : FT-REG: Management Files Activity - Properties at the Act… (#4859) * CI: Bump version to v5.11.0-106.3 * PSP-10592 Add new layers: Parcel by Class, Parcel by Owner Type (#4863) * CI: Bump version to v5.11.0-106.4 * migrate to new type instead of IMapProperty. * Added buttons to zoom into properties from files * PSP-10458 fix * update file property sidebar to use property id instead of index to promote consistency. * Properties view changes * CI: Bump version to v5.11.0-106.5 * Repaired 105 Fixed PIMS_RESEARCH_BOUNDARY_VW * CI: Bump version to v5.11.0-106.6 * Added PID layer. Removed old layer definition * PR improvements * Regenerated scaffold * Updated layer definition to use the boundary * CI: Bump version to v5.11.0-106.7 * CI: Bump version to v5.11.0-106.8 * PSP-10365 : Management File - Permissions - Business Rules (#4843) * CI: Bump version to v5.11.0-106.9 * update ordering logic. * Updated Management Activity Type and Subtype Added disabled codes 'UNKNOWN' for backward compatibility. * CI: Bump version to v5.11.0-106.10 * Added marker to location related searches (#4871) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.11 * Regenerated snaps * psp-10487 inability to upload larger files. * handle null/undefined error. * CI: Bump version to v5.11.0-106.12 * Fixed properties boundaries not being taken into account * CI: Bump version to v5.11.0-106.13 * psp-10487 increase stability of mayan document upload - refactor logic. * Merge pull request #4873 from devinleighsmith/dev psp-10487 - allow upload of larger files - report errors correctly * CI: Bump version to v5.11.0-106.14 * psp-10487 address major memory useage outliers. (#4880) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.11.0-106.15 * PSP-10565: Adding a Contact in Property via Management tab is not adding a contact (#4877) * PSP-10565 * Deleting unnecessary variables --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.16 * code review comments. * code review comments. * test updates. * CI: Bump version to v5.11.0-106.17 * sonar recommendations. * CI: Bump version to v5.11.0-106.18 * PSP-9090 Geocoder autocomplete parameter for direct match (#4879) * Update parameters to match latest BC Geocoder API * Lint fixes * Use correct default values * Test updates * CI: Bump version to v5.11.0-106.19 * PSP-10565: InventoryTab issue (#4882) * PSP-10565 * Deleting unnecessary variables * Fixing InventoryTabs issue --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.20 * PSP-10338 Fix (#4875) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.21 * PSP-10194 : Property information without PIN/PID (#4881) * CI: Bump version to v5.11.0-106.22 * psp-10562 (#4883) * psp-10562 marked location popups should allow clicks. clicking elsewhere on the map should not remove makred location popups. allow zooming to lat/lng in addition to boundaries. * test updates. * CI: Bump version to v5.11.0-106.23 * Psp 10572 hold acquisition files allow take editing. (#4884) * psp-10572 fix hold status allowing take changes. * test correction. --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.24 * property management view fields. (#4885) * CI: Bump version to v5.11.0-106.25 * FT-REG: Management Files Activity - Properties at the Activity Details level are not saved properly (#4886) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.11.0-106.26 * PSP-10565: UAT. Adding a Contact in Property via Management tab is not adding a contact - additional fix (#4888) * PSP-10565 * Deleting unnecessary variables * Fixing InventoryTabs issue * PSP-10565 fix --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.27 * PSP-10572 ensure that the file property is set on the passed fileProperty instance. (#4889) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.28 * PSP-10645 : FT:Management : non-admin is still able to see the edit icon on the file summary tab if the status is hold or cancelled (#4890) Co-authored-by: Herrera <eduardo.herrera@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.29 * stop using saveChangesAsync - not supported for now. * CI: Bump version to v5.11.0-106.30 * psp-10641 ensure that lat/lng is always set, even if pid is found. (#4894) * CI: Bump version to v5.11.0-106.31 * do not copy stream, just apply directly to output content - to reduce… (#4896) * do not copy stream, just apply directly to output content - to reduce memory footprint. * apply same stream pattern to clamav. * include missing clamav service in solution. * limit number of queue workers. * test corrections. * CI: Bump version to v5.11.0-106.32 * psp-10647 ensure that draft disabled markers display differently. (#4897) * CI: Bump version to v5.11.0-106.33 * Allow admins to change a file to an active status. (#4899) * CI: Bump version to v5.11.0-106.34 * PSP-9747: UI UX Clean Up - Acquisition File - Expropriation screens (#4874) * PSP-9747 changes * Changes on the SectionLisrHeader to accomodate Generate button * ExpropriationTabContainerView changes * Changes on unit test * Unit tests changes * Undo changes on ManagementActivityEditForm * Changes on PSP-9747 * Lint of ExpropriationTabContainerView * Lint of ExpropriationForm9.text * Changes based on feedback --------- Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.11.0-106.35 * PSP-10662 : FT:Registered owner information is not populated under Charges on Strata Common Property section in the property Plan Tab (#4901) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.11.0-106.36 --------- Co-authored-by: devinleighsmith <devinleighsmith@gmail.com> Co-authored-by: Eduardo <eddherrera@users.noreply.github.com> Co-authored-by: Herrera <eduardo.herrera@quartech.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sue Tairaku <42981334+stairaku@users.noreply.github.com> Co-authored-by: Manuel Rodriguez <marobej@gmail.com> Co-authored-by: Sue Tairaku <sue.tairaku@gmail.com> Co-authored-by: dfilteau <dfilteau@hilltopz.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> Co-authored-by: Smith <devin.smith@quartech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erty instance.