Skip to content

Release 5.14#5118

Merged
uhelm merged 653 commits intobcgov:masterfrom
devinleighsmith:master
Dec 11, 2025
Merged

Release 5.14#5118
uhelm merged 653 commits intobcgov:masterfrom
devinleighsmith:master

Conversation

@devinleighsmith
Copy link
Copy Markdown
Collaborator

No description provided.

FuriousLlama and others added 30 commits September 24, 2025 13:55
psp-10181 & psp-4160 | Added new generation forms
…ect to property - activity screens (bcgov#5008)

* psp-10637 management file navigation correction

* remove unused code.

* test correction.

* limit the redis history on hangfire jobs - to redus redis AOF file size.
* Added geoserver layers to the gitignore file

* Added geoserver layers to the gitignore file

* Added geoserver layers to the gitignore file

* Added geoserver layers to the gitignore file
…Properties to include in this file" on the create screen of Acq file (bcgov#5010)
…roperties search (bcgov#5017)

* Playwright digital documents

* linting

* property automation updates

* Linting

* Automation updates

* Updating Selenium automation with Github observations
* Backend changes for management activity invoice report

* Frontend UI + logic for activity invoice report

* Fix cycle in EF query

* Rename mock file, update related tests

* Rename mock functions

* Test updates

* Sonar fix

* Fix frontend faulty logic  with non-dismissible modal

* Linting

* CR feedback

* typo

* Test updates

* Backend test updates
* psp-10796 access request user information corrections.

* snapshot correction.

* snapshot updates.

* test correction.

* snapshot update.

* snapshot update.
* IS-111.00 Database Schema

PSP_PIMS | Development Sprint: S111.00 | Design Sprint: 110 | Date: 2025-Sep-23
- Altered tables:
  - PIMS_ACCESS_REQUEST
  - PIMS_ACCESS_REQUEST_ORGANIZATION
  - PIMS_ACCESS_REQUEST_STATUS_TYPE
  - PIMS_ACQUISITION_CHECKLIST_ITEM
  - PIMS_ACQUISITION_FILE
  - PIMS_ACQUISITION_FILE_DOCUMENT
  - PIMS_ACQUISITION_FILE_FORM
  - PIMS_ACQUISITION_FILE_NOTE
  - PIMS_ACQUISITION_FILE_STATUS_TYPE
  - PIMS_ACQUISITION_FILE_TEAM
  - PIMS_ACQUISITION_FUNDING_TYPE
  - PIMS_ACQUISITION_OWNER
  - PIMS_ACQUISITION_TYPE
  - PIMS_ACQ_CHKLST_ITEM_TYPE
  - PIMS_ACQ_CHKLST_SECTION_TYPE
  - PIMS_ACQ_FILE_ACQ_FL_TAKE_TYP
  - PIMS_ACQ_FILE_ACQ_PROGRESS
  - PIMS_ACQ_FILE_APPRAISAL_TYPE
  - PIMS_ACQ_FILE_EXPROP_RISK_TYPE
  - PIMS_ACQ_FILE_LGL_SRVY_TYPE
  - PIMS_ACQ_FILE_PROGESS_TYPE
  - PIMS_ACQ_FILE_TAKE_TYPE
  - PIMS_ACQ_FL_TEAM_PROFILE_TYPE
  - PIMS_ACQ_PHYS_FILE_STATUS_TYPE
  - PIMS_ADDRESS
  - PIMS_ADDRESS_USAGE_TYPE
  - PIMS_AGREEMENT
  - PIMS_AGREEMENT_STATUS_TYPE
  - PIMS_AGREEMENT_TYPE
  - PIMS_AREA_UNIT_TYPE
  - PIMS_BUSINESS_FUNCTION_CODE
  - PIMS_CHART_OF_ACCOUNTS_CODE
  - PIMS_CHKLST_ITEM_STATUS_TYPE
  - PIMS_CLAIM
  - PIMS_COMPENSATION_REQUISITION
  - PIMS_COMP_REQ_ACQ_PAYEE
  - PIMS_COMP_REQ_FINANCIAL
  - PIMS_COMP_REQ_LEASE_PAYEE
  - PIMS_CONSULTATION_OUTCOME_TYPE
  - PIMS_CONSULTATION_STATUS_TYPE
  - PIMS_CONSULTATION_TYPE
  - PIMS_CONTACT_METHOD
  - PIMS_CONTACT_METHOD_TYPE
  - PIMS_COST_TYPE_CODE
  - PIMS_COUNTRY
  - PIMS_DATA_SOURCE_TYPE
  - PIMS_DISPOSITION_APPRAISAL
  - PIMS_DISPOSITION_CHECKLIST_ITEM
  - PIMS_DISPOSITION_FILE
  - PIMS_DISPOSITION_FILE_DOCUMENT
  - PIMS_DISPOSITION_FILE_NOTE
  - PIMS_DISPOSITION_FILE_PROPERTY
  - PIMS_DISPOSITION_FILE_STATUS_TYPE
  - PIMS_DISPOSITION_FILE_TEAM
  - PIMS_DISPOSITION_FUNDING_TYPE
  - PIMS_DISPOSITION_INITIATING_DOC_TYPE
  - PIMS_DISPOSITION_OFFER
  - PIMS_DISPOSITION_OFFER_STATUS_TYPE
  - PIMS_DISPOSITION_PURCHASER
  - PIMS_DISPOSITION_SALE
  - PIMS_DISPOSITION_STATUS_TYPE
  - PIMS_DISPOSITION_TYPE
  - PIMS_DISTRICT
  - PIMS_DOCUMENT
  - PIMS_DOCUMENT_CATEGORY_SUBTYPE
  - PIMS_DOCUMENT_CATEGORY_TYPE
  - PIMS_DOCUMENT_FORMAT_TYPE
  - PIMS_DOCUMENT_QUEUE
  - PIMS_DOCUMENT_QUEUE_STATUS_TYPE
  - PIMS_DOCUMENT_STATUS_TYPE
  - PIMS_DOCUMENT_TYP
  - PIMS_DSP_CHKLST_ITEM_TYPE
  - PIMS_DSP_CHKLST_SECTION_TYPE
  - PIMS_DSP_FL_TEAM_PROFILE_TYPE
  - PIMS_DSP_INITIATING_BRANCH_TYPE
  - PIMS_DSP_PHYS_FILE_STATUS_TYPE
  - PIMS_DSP_PURCH_AGENT
  - PIMS_DSP_PURCH_SOLICITOR
  - PIMS_EXPROPRIATION_PAYMENT
  - PIMS_EXPROP_OWNER_HISTORY
  - PIMS_EXPROP_OWNER_HISTORY_TYPE
  - PIMS_EXPROP_PMT_PMT_ITEM
  - PIMS_FENCE_TYPE
  - PIMS_FINANCIAL_ACTIVITY_CODE
  - PIMS_FORM_TYPE
  - PIMS_H120_CATEGORY
  - PIMS_HISTORICAL_FILE_NUMBER
  - PIMS_HISTORICAL_FILE_NUMBER_TYPE
  - PIMS_INSURANCE
  - PIMS_INSURANCE_TYPE
  - PIMS_INTEREST_HOLDER
  - PIMS_INTEREST_HOLDER_INTEREST_TYPE
  - PIMS_INTEREST_HOLDER_TYPE
  - PIMS_INTHLDR_PROP_INTEREST
  - PIMS_LAND_ACT_TYPE
  - PIMS_LAND_SURVEYOR_TYPE
  - PIMS_LEASE
  - PIMS_LEASE_CHECKLIST_ITEM
  - PIMS_LEASE_CHKLST_ITEM_TYPE
  - PIMS_LEASE_CHKLST_SECTION_TYPE
  - PIMS_LEASE_CONSULTATION
  - PIMS_LEASE_DOCUMENT
  - PIMS_LEASE_INITIATOR_TYPE
  - PIMS_LEASE_LEASE_PURPOSE
  - PIMS_LEASE_LICENSE_TEAM
  - PIMS_LEASE_LICENSE_TYPE
  - PIMS_LEASE_NOTE
  - PIMS_LEASE_PAYMENT
  - PIMS_LEASE_PAYMENT_CATEGORY_TYPE
  - PIMS_LEASE_PAYMENT_METHOD_TYPE
  - PIMS_LEASE_PAYMENT_STATUS_TYPE
  - PIMS_LEASE_PAY_RVBL_TYPE
  - PIMS_LEASE_PERIOD
  - PIMS_LEASE_PERIOD_STATUS_TYPE
  - PIMS_LEASE_PMT_FREQ_TYPE
  - PIMS_LEASE_PROGRAM_TYPE
  - PIMS_LEASE_PURPOSE_TYPE
  - PIMS_LEASE_RENEWAL
  - PIMS_LEASE_RESPONSIBILITY_TYPE
  - PIMS_LEASE_STAKEHOLDER
  - PIMS_LEASE_STAKEHOLDER_TYPE
  - PIMS_LEASE_STATUS_TYPE
  - PIMS_LESSOR_TYPE
  - PIMS_LETTER_TYPE
  - PIMS_LL_TEAM_PROFILE_TYPE
  - PIMS_MANAGEMENT_ACTIVITY
  - PIMS_MANAGEMENT_ACTIVITY_INVOICE
  - PIMS_MANAGEMENT_ACTIVITY_PROPERTY
  - PIMS_MANAGEMENT_FILE
  - PIMS_MANAGEMENT_FILE_CONTACT
  - PIMS_MANAGEMENT_FILE_DOCUMENT
  - PIMS_MANAGEMENT_FILE_NOTE
  - PIMS_MANAGEMENT_FILE_PROFILE_TYPE
  - PIMS_MANAGEMENT_FILE_PROPERTY
  - PIMS_MANAGEMENT_FILE_PURPOSE_TYPE
  - PIMS_MANAGEMENT_FILE_STATUS_TYPE
  - PIMS_MANAGEMENT_FILE_TEAM
  - PIMS_MGMT_ACTIVITY_ACTIVITY_SUBTYP
  - PIMS_MGMT_ACTIVITY_DOCUMENT
  - PIMS_MGMT_ACTIVITY_STATUS_TYPE
  - PIMS_MGMT_ACTIVITY_SUBTYPE
  - PIMS_MGMT_ACTIVITY_TYPE
  - PIMS_MGMT_ACT_INVOLVED_PARTY
  - PIMS_MGMT_ACT_MIN_CONTACT
  - PIMS_NOTE
  - PIMS_ORGANIZATION
  - PIMS_ORGANIZATION_ADDRESS
  - PIMS_ORGANIZATION_TYPE
  - PIMS_ORG_IDENTIFIER_TYPE
  - PIMS_PAYMENT_ITEM_TYPE
  - PIMS_PERSON
  - PIMS_PERSON_ADDRESS
  - PIMS_PERSON_ORGANIZATION
  - PIMS_PERSON_ORGANIZATION
  - PIMS_PPH_STATUS_TYPE
  - PIMS_PRF_PROP_RESEARCH_PURPOSE_TYP
  - PIMS_PRF_PROP_RESEARCH_PURPOSE_TYP_HIST
  - PIMS_PRODUCT
  - PIMS_PROJECT
  - PIMS_PROJECT_DOCUMENT
  - PIMS_PROJECT_NOTE
  - PIMS_PROJECT_PERSON
  - PIMS_PROJECT_PERSON_ROLE_TYPE
  - PIMS_PROJECT_PRODUCT
  - PIMS_PROJECT_STATUS_TYPE
  - PIMS_PROPERTY
  - PIMS_PROPERTY_ACQUISITION_FILE
  - PIMS_PROPERTY_ANOMALY_TYPE
  - PIMS_PROPERTY_CONTACT
  - PIMS_PROPERTY_DOCUMENT
  - PIMS_PROPERTY_IMPROVEMENT
  - PIMS_PROPERTY_IMPROVEMENT_TYPE
  - PIMS_PROPERTY_LEASE
  - PIMS_PROPERTY_NOTE
  - PIMS_PROPERTY_OPERATION
  - PIMS_PROPERTY_OPERATION_TYPE
  - PIMS_PROPERTY_ORGANIZATION
  - PIMS_PROPERTY_PURPOSE_TYPE
  - PIMS_PROPERTY_RESEARCH_FILE
  - PIMS_PROPERTY_ROAD_TYPE
  - PIMS_PROPERTY_STATUS_TYPE
  - PIMS_PROPERTY_TENURE_TYPE
  - PIMS_PROPERTY_TYPE
  - PIMS_PROP_ACQ_FL_COMP_REQ
  - PIMS_PROP_INTHLDR_INTEREST_TYP
  - PIMS_PROP_LEASE_COMP_REQ
  - PIMS_PROP_PROP_ANOMALY_TYP
  - PIMS_PROP_PROP_PURPOSE
  - PIMS_PROP_PROP_ROAD_TYP
  - PIMS_PROP_PROP_TENURE_TYP
  - PIMS_PROP_RESEARCH_PURPOSE_TYPE
  - PIMS_PROP_TENURE_CLEANUP
  - PIMS_PROVINCE_STATE
  - PIMS_REGION
  - PIMS_REGION_USER
  - PIMS_REQUEST_SOURCE_TYPE
  - PIMS_RESEARCH_FILE
  - PIMS_RESEARCH_FILE_DOCUMENT
  - PIMS_RESEARCH_FILE_NOTE
  - PIMS_RESEARCH_FILE_PROJECT
  - PIMS_RESEARCH_FILE_PURPOSE
  - PIMS_RESEARCH_FILE_STATUS_TYPE
  - PIMS_RESEARCH_PURPOSE_TYPE
  - PIMS_RESPONSIBILITY_CODE
  - PIMS_ROLE
  - PIMS_ROLE_CLAIM
  - PIMS_SECURITY_DEPOSIT
  - PIMS_SECURITY_DEPOSIT_HOLDER
  - PIMS_SECURITY_DEPOSIT_RETURN
  - PIMS_SECURITY_DEPOSIT_RETURN_HOLDER
  - PIMS_SECURITY_DEPOSIT_TYPE
  - PIMS_STATIC_VARIABLE
  - PIMS_SUBFILE_INTEREST_TYPE
  - PIMS_SURPLUS_DECLARATION_TYPE
  - PIMS_SURVEY_PLAN_TYPE
  - PIMS_TAKE
  - PIMS_TAKE_SITE_CONTAM_TYPE
  - PIMS_TAKE_STATUS_TYPE
  - PIMS_TAKE_TYPE
  - PIMS_TAX_RESPONSIBILITY_TYPE
  - PIMS_TENANT
  - PIMS_TENURE_CLEANUP_TYPE
  - PIMS_USER
  - PIMS_USER_ORGANIZATION
  - PIMS_USER_ROLE
  - PIMS_USER_TYPE
  - PIMS_UTILITY_RESPONSIBILITY_TYPE
  - PIMS_VOLUMETRIC_TYPE
  - PIMS_VOLUME_UNIT_TYPE
  - PIMS_WORK_ACTIVITY_CODE
  - PIMS_YEARLY_FINANCIAL_CODE

* Master SQL Added to Alter folders

* Changed // to -- comments
Co-authored-by: Herrera <eduardo.herrera@quartech.com>
devinleighsmith and others added 20 commits November 13, 2025 08:14
add override assemble file to ensure hotfixes built with npm ci
…ies (bcgov#5097)

* Support adding lat/long on create file screens

* Linting

* Cover regression bug with updated tests
* pinned versions.

* add exclusions from dev.
bcgov#5108)

Co-authored-by: Herrera <eduardo.herrera@quartech.com>
Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
…ng the boundaries of search results on the map
[HOTFIX]: Search Control: Project:Search by Project is not highlighting the boundaries of search results on the map
Comment on lines +18 to +40
runs-on: ubuntu-22.04

defaults:
run:
working-directory: ./testing/playwright-testing

steps:
- name: Checkout repository
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1

- name: Setup Node.js
uses: actions/setup-node@49933ea5f5257e8e3239177f8295fda8298b857f # v4
with:
node-version: "20"

- name: Install Dependencies
run: npm ci

- name: Install Playwright Browsers
run: npx playwright install --with-deps

- name: 🚀 Run Cucumber Smoke Tests
run: npx cucumber-js --tags @smokeTest

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
export default GenerateLetterContainer;

const getInterestTypeString = (codeType: string): RecipientType => {
let interestString: RecipientType = 'HLDR';

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

The initial value of interestString is unused, since it is always overwritten.
}));

const mockExecuteRaw = vi.fn();
const mockLoading = false;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable mockLoading.
const remove = vi.fn();
const clearAll = vi.fn();
const requestFlyToBounds = vi.fn();
const requestFlyToLocation = vi.fn();

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable requestFlyToLocation.
const select = vi.fn();
const remove = vi.fn();
const clearAll = vi.fn();
const requestFlyToBounds = vi.fn();

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable requestFlyToBounds.
import { IMapStateMachineContext } from '@/components/common/mapFSM/MapStateMachineContext';
import { mapMachineBaseMock } from '@/mocks/mapFSM.mock';
import { getMockWorklistParcel } from '@/mocks/worklistParcel.mock';
import { act, render, RenderOptions, screen } from '@/utils/test-utils';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import act.
@@ -0,0 +1,82 @@
import { IMapStateMachineContext } from '@/components/common/mapFSM/MapStateMachineContext';
import { mapMachineBaseMock } from '@/mocks/mapFSM.mock';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import mapMachineBaseMock.
@@ -0,0 +1,82 @@
import { IMapStateMachineContext } from '@/components/common/mapFSM/MapStateMachineContext';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import IMapStateMachineContext.
@@ -32,19 +37,23 @@
waitForEffects,
} from '@/utils/test-utils';

import { PropertyFilterFormModel } from '@/components/maps/leaflet/Control/AdvancedFilter/models';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import PropertyFilterFormModel.
@@ -0,0 +1,37 @@
import { act, render, RenderOptions, userEvent } from '@/utils/test-utils';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports act, userEvent.
@@ -0,0 +1,72 @@
import React from 'react';
import { render, fireEvent, getByTitle } from '@/utils/test-utils';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import getByTitle.
@github-actions
Copy link
Copy Markdown
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5118

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9 Security Hotspots
78.7% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions
Copy link
Copy Markdown
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5118

@uhelm uhelm merged commit ca00f1e into bcgov:master Dec 11, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants