PSP-10953 : Surplus Declaration at Property Level#5119

Merged

eddherrera merged 12 commits intobcgov:devfrom

eddherrera:psp-10953

Dec 24, 2025

Collaborator

eddherrera commented Dec 12, 2025

No description provided.


          PSP-10953 : Surplus Declaration at Property Level

186f2f1

eddherrera requested a review from asanchezr

December 12, 2025 23:17

eddherrera self-assigned this

Herrera added 2 commits

December 15, 2025 13:20


          Merge branch 'dev' into psp-10953

f7d4ea3

# Conflicts:
#	source/backend/api/Controllers/LookupController.cs
#	source/backend/dal/Repositories/Interfaces/ILookupRepository.cs
#	source/backend/dal/Repositories/LookupRepository.cs
#	source/backend/dal/Repositories/PropertyRepository.cs
#	source/frontend/src/constants/API.ts
#	source/frontend/src/features/mapSideBar/property/tabs/propertyDetails/update/models/UpdatePropertyDetailsFormModel.ts
#	source/frontend/src/mocks/lookups.mock.ts


          - test updates

939f088

github-advanced-security bot found potential problems

View reviewed changes

...src/features/mapSideBar/property/tabs/propertyDetails/detail/PropertyDetailsTabView.test.tsx Fixed Show fixed Hide fixed

...ures/mapSideBar/property/tabs/propertyDetails/update/UpdatePropertyDetailsContainer.test.tsx Fixed Show fixed Hide fixed

...ures/mapSideBar/property/tabs/propertyDetails/update/UpdatePropertyDetailsContainer.test.tsx Fixed Show fixed Hide fixed

...ures/mapSideBar/property/tabs/propertyDetails/update/UpdatePropertyDetailsContainer.test.tsx Fixed Show fixed Hide fixed

.../features/mapSideBar/property/tabs/propertyDetails/update/UpdatePropertyDetailsForm.test.tsx Fixed Show fixed Hide fixed

devinleighsmith approved these changes

View reviewed changes

Collaborator

devinleighsmith left a comment

please address codeql warnings.

Collaborator

devinleighsmith commented Dec 19, 2025

@eddherrera are you aware that this is still in draft? please complete this ticket before working on bugs.

Herrera added 2 commits

December 19, 2025 11:47


          Merge branch 'dev' into psp-10953

7f19fc5


          - linting

08883ce

eddherrera marked this pull request as ready for review

December 19, 2025 19:50

Herrera added 5 commits

December 19, 2025 12:07


          - linting

d0ab1ba


          - unit test updates

39277d4


          Merge branch 'dev' into psp-10953

ae91199


          - Unit test updates

80dfb3e


          - unit test updates (backend)

87e2685

github-advanced-security bot found potential problems

View reviewed changes

source/backend/entities/Partials/Property.cs

-                          this.PropertyAreaUnitTypeCodeNavigation = areaUnit ?? throw new ArgumentNullException(nameof(areaUnit));
-                          this.PropertyAreaUnitTypeCode = areaUnit.Id;
+                          Pid = pid > 0 ? pid : null;
+                          PropertyTypeCodeNavigation = type ?? throw new ArgumentNullException(nameof(type));

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

source/backend/entities/Partials/Property.cs

+                          Pid = pid > 0 ? pid : null;
+                          PropertyTypeCodeNavigation = type ?? throw new ArgumentNullException(nameof(type));
+                          PropertyTypeCode = type.Id;
+                          Address = address ?? throw new ArgumentNullException(nameof(address));

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

source/backend/entities/Partials/Property.cs

+                          PropertyTypeCode = type.Id;
+                          Address = address ?? throw new ArgumentNullException(nameof(address));
+                          AddressId = address.AddressId;
+                          RegionCode = address.RegionCode.Value;

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

may be null at this access because it has a nullable type.

source/backend/entities/Partials/Property.cs

+                          Address = address ?? throw new ArgumentNullException(nameof(address));
+                          AddressId = address.AddressId;
+                          RegionCode = address.RegionCode.Value;
+                          DistrictCode = address.DistrictCode.Value;

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

may be null at this access because it has a nullable type.

source/backend/entities/Partials/Property.cs

+                          AddressId = address.AddressId;
+                          RegionCode = address.RegionCode.Value;
+                          DistrictCode = address.DistrictCode.Value;
+                          PimsPropPropTenureTyps = new List<PimsPropPropTenureTyp>() { tenure };

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

source/backend/entities/Partials/Property.cs

+                          RegionCode = address.RegionCode.Value;
+                          DistrictCode = address.DistrictCode.Value;
+                          PimsPropPropTenureTyps = new List<PimsPropPropTenureTyp>() { tenure };
+                          PropertyAreaUnitTypeCodeNavigation = areaUnit ?? throw new ArgumentNullException(nameof(areaUnit));

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

source/backend/entities/Partials/Property.cs

-                          this.PropertyDataSourceEffectiveDate = DateOnly.FromDateTime(dataSourceEffectiveDate);
-                          this.PropertyStatusTypeCodeNavigation = status ?? throw new ArgumentNullException(nameof(status));
-                          this.PropertyStatusTypeCode = status.Id;
+                          PropertyDataSourceTypeCodeNavigation = dataSource ?? throw new ArgumentNullException(nameof(dataSource));

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

source/backend/entities/Partials/Property.cs

+                          PropertyDataSourceTypeCodeNavigation = dataSource ?? throw new ArgumentNullException(nameof(dataSource));
+                          PropertyDataSourceTypeCode = dataSource.Id;
+                          PropertyDataSourceEffectiveDate = DateOnly.FromDateTime(dataSourceEffectiveDate);
+                          PropertyStatusTypeCodeNavigation = status ?? throw new ArgumentNullException(nameof(status));

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

source/backend/tests/dal/Repositories/PropertyRepositoryTest.cs Fixed Show fixed Hide fixed

Contributor

github-actions bot commented Dec 23, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5119


          - unit test updates

929e888

sonarqubecloud bot commented Dec 23, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarQube Cloud

Contributor

github-actions bot commented Dec 23, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5119


          - test update

cf654b0

Contributor

github-actions bot commented Dec 23, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5119

1 similar comment

Contributor

github-actions bot commented Dec 23, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5119

eddherrera added this pull request to the merge queue

Merged via the queue into bcgov:dev with commit 0f6eff1

16 checks passed

eddherrera deleted the psp-10953 branch

January 7, 2026 19:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet