Psp 11036 fix mismatch in draft marker numbering#5132
Merged
devinleighsmith merged 11 commits intobcgov:devfrom Jan 5, 2026
Merged
Psp 11036 fix mismatch in draft marker numbering#5132devinleighsmith merged 11 commits intobcgov:devfrom
devinleighsmith merged 11 commits intobcgov:devfrom
Conversation
devinleighsmith
force-pushed
the
psp-11036
branch
2 times, most recently
from
e59a374 to
f8466ed
Compare
asanchezr
reviewed
Dec 24, 2025
Comment on lines
+76
to
+90
| const renderPropertyIcon = ( | ||
| fileProperty: ApiGen_Concepts_FileProperty, | ||
| filePropertyIndex: number | null, | ||
| ) => { | ||
| if (!exists(filePropertyIndex)) { | ||
| return null; | ||
| } | ||
|
|
||
| if (fileProperty?.property?.isRetired) { | ||
| return ( | ||
| <StyledDisabledIconWrapper> | ||
| {sortedProperties.indexOf(fileProperty) + 1} | ||
| </StyledDisabledIconWrapper> | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
nit: this function is receiving a number of parameters but also using sortedProperties as a closure. I would prefer to also pass in the sorted array as a parameter for consistency and to avoid closure issues
asanchezr
approved these changes
Dec 25, 2025
…t appear on the map.
Signed-off-by: devinleighsmith <devinleighsmith@gmail.com>
devinleighsmith
force-pushed
the
psp-11036
branch
from
f8466ed to
5ca0a2e
Compare
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5132 |
|
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.