Skip to content

PSP-11013: Implement warning message before leaving an updating form#5138

Merged
areyeslo merged 6 commits intobcgov:devfrom
areyeslo:PSP-11013-ImplementWarningMessage-UpdateForm
Jan 21, 2026
Merged

PSP-11013: Implement warning message before leaving an updating form#5138
areyeslo merged 6 commits intobcgov:devfrom
areyeslo:PSP-11013-ImplementWarningMessage-UpdateForm

Conversation

@areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Jan 6, 2026

With this change all forms that update data display a warning message when the user attempts to leave without saving changes.

Story

@areyeslo areyeslo self-assigned this Jan 6, 2026
@areyeslo areyeslo added the enhancement New feature or request label Jan 6, 2026
@areyeslo areyeslo force-pushed the PSP-11013-ImplementWarningMessage-UpdateForm branch 4 times, most recently from 015bbf5 to d3f3f72 Compare January 7, 2026 00:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5138

@areyeslo areyeslo marked this pull request as ready for review January 7, 2026 01:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5138

@devinleighsmith
Copy link
Collaborator

devinleighsmith commented Jan 9, 2026

This looks close, However I found a regression when the "user override" modals are being displayed. Here is how to reproduce:

  1. open an existing management or disposition file.
  2. edit the properties on that file.
  3. add a new property from the map that is not already in PIMS.
  4. you should see a warning: User Override Required modal.
  5. click yes.

Expected: should be taken back to the view file details screen.
Actual: navigated to an empty version of the edit file properties screen.

@areyeslo

Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment.

@github-actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5138

@devinleighsmith
Copy link
Collaborator

@areyeslo retested, different behaviour now but still incorrect, after the user override is confirmed the user should be taken back to the view screen but they are being taken back to the property edit screen. They have to accept the user override modal a second time before they are able to save.

@areyeslo areyeslo force-pushed the PSP-11013-ImplementWarningMessage-UpdateForm branch 2 times, most recently from 4485c26 to ded882e Compare January 14, 2026 03:27
@github-actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5138

@areyeslo areyeslo force-pushed the PSP-11013-ImplementWarningMessage-UpdateForm branch 2 times, most recently from 896dcac to 2d3a913 Compare January 15, 2026 14:28
@github-actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5138

@areyeslo
Copy link
Collaborator Author

@devinleighsmith please take a look.

@areyeslo areyeslo force-pushed the PSP-11013-ImplementWarningMessage-UpdateForm branch from 2d3a913 to fc3e7b8 Compare January 21, 2026 00:22
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5138

@areyeslo areyeslo added this pull request to the merge queue Jan 21, 2026
Merged via the queue into bcgov:dev with commit b6b1edc Jan 21, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants