psp-11100 fix polygon upload json parsing error.#5160
Merged
Conversation
…require a fix on the SP in our next release to avoid deadlocking.
asanchezr
approved these changes
Jan 15, 2026
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5160 |
1 similar comment
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5160 |
asanchezr
reviewed
Jan 15, 2026
| const shapeFeatures = await request.toGeoJson(); | ||
| response.isSuccess = true; | ||
| response.boundary = firstOrNull(shapeFeatures.features)?.geometry as Polygon | MultiPolygon; | ||
| response.boundary.bbox = undefined; // remove bbox as this can cause issues with polygon json parsing on the backend. |
Collaborator
There was a problem hiding this comment.
this can create NPE if the parsed shape returns null
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5160 |
1 similar comment
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5160 |
|
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5160 |
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5160 |
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5160 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.