Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
source/backend/tests/api/Services/AcquisitionFileServiceTest.cs
Dismissed
Show dismissed
Hide dismissed
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
areyeslo
force-pushed
the
PSP-11077-UnableEditPropertiesWithRetiredProperties
branch
from
3058dbf to
9d41b24
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
areyeslo
force-pushed
the
PSP-11077-UnableEditPropertiesWithRetiredProperties
branch
from
9d41b24 to
f48110c
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
areyeslo
force-pushed
the
PSP-11077-UnableEditPropertiesWithRetiredProperties
branch
from
f48110c to
4389575
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
formik may be not reliable.
areyeslo
force-pushed
the
PSP-11077-UnableEditPropertiesWithRetiredProperties
branch
from
4389575 to
0797d98
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
|
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5164 |
2 participants
Only block new retired properties from being added.
Allow edits/removal of already-attached retired properties.
Validation is implemented in the backend which handles complex validations instead of frontend.
Note: When implementing customized validation, Formik’s error state is updated after the next render cycle. Then, found
"validates form values upon submission"test failing because the textPlease check form fields for errorswas not present in the DOM immediately after click, the error state may not have propagated yet, so the error message is not rendered causing the test to fail.Story