Skip to content

PSP-11133 Add layer for Completed Disposition files#5171

Merged
asanchezr merged 6 commits intobcgov:devfrom
asanchezr:psp-11133-completed-disposition-layer
Jan 27, 2026
Merged

PSP-11133 Add layer for Completed Disposition files#5171
asanchezr merged 6 commits intobcgov:devfrom
asanchezr:psp-11133-completed-disposition-layer

Conversation

@asanchezr
Copy link
Collaborator

NOTE: This PR also includes updated layer styles for local geoserver to match the deployed layer styles

image

@asanchezr asanchezr self-assigned this Jan 22, 2026
@asanchezr asanchezr added enhancement New feature or request 5.16 labels Jan 22, 2026
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
24.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5171

<?xml version="1.0" encoding="UTF-8"?><sld:StyledLayerDescriptor xmlns:sld="http://www.opengis.net/sld" xmlns="http://www.opengis.net/sld" xmlns:gml="http://www.opengis.net/gml" xmlns:ogc="http://www.opengis.net/ogc" version="1.0.0">
<sld:NamedLayer>
<sld:Name>land_act_take_style</sld:Name>
<sld:Name>Default Styler</sld:Name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to add a descriptive name instead of using the default provided by GeoServer's web UI.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles (*.SLD) were copied from the deployed styles in MOTT geoserver. I think we would benefit from mirroring their configuration so that we can troubleshoot issues better on our local environment,

<sld:Title>acquisition</sld:Title>
<sld:PolygonSymbolizer>
<sld:Fill>
<sld:GraphicFill>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this we are removing the pattern fill from polygon. In PIMS we use only solid colors.


<NamedLayer>
<Name>pims_property</Name>
<Name>bctfa_property</Name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this change we are matching layerIdentifier in LayerDefinition.ts and LayersMenuLayout.tsx

Copy link
Collaborator

@areyeslo areyeslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@asanchezr asanchezr added this pull request to the merge queue Jan 27, 2026
Merged via the queue into bcgov:dev with commit 5e98f41 Jan 27, 2026
14 of 15 checks passed
@asanchezr asanchezr deleted the psp-11133-completed-disposition-layer branch February 2, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.16 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants