Conversation
source/backend/api/Helpers/Extensions/PrincipalExtensions.cs
Dismissed
Show dismissed
Hide dismissed
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5184 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5184 |
…factor related methods for clarity
…k; add project fetching logic and validation
…n CompensationRequisitionService
c0371bc to
013d7e4
Compare
|
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5184 |
|
@asanchezr please address codeQl warnings if relevant. Also, seeing some behaviour on lease creation that may not be consistent with acquisition.
|
@devinleighsmith - The codeql warnings seem weird but will take a look (most are on test files) The behaviour you see with property region assigned to file region I can see it already existing in DEV (so not related to this changes). Both Leases and Acquisition will send the northern region on the file submission if the first property added is in northern region - regardless of whether user is contractor/staff and regardless of user region access. This seems like an existing bug. If you agree I will ask Praveen to validate and create a bug ticket and we can fix that separate from this PR. Sounds good? This is the error I get as a staff (not contractor) creating an acquisition file when I don't have access to northern region |




Create lease restriction
Update lease restriction