Skip to content

PSP-10827: PIMS H-forms Templates: H-0179(RC), Agreement of Purchase and Sale (Closed Road)#5220

Merged
areyeslo merged 13 commits intobcgov:devfrom
areyeslo:PSP-10827-H-0179-RC
Feb 23, 2026
Merged

PSP-10827: PIMS H-forms Templates: H-0179(RC), Agreement of Purchase and Sale (Closed Road)#5220
areyeslo merged 13 commits intobcgov:devfrom
areyeslo:PSP-10827-H-0179-RC

Conversation

@areyeslo
Copy link
Copy Markdown
Collaborator

@areyeslo areyeslo commented Feb 19, 2026 •
edited
Loading

Generation of H-0179(RC):
image

Document Variables:
Purchaser:
image

Plan Number with commas:
image

Legal Description:
image

Purchaser & Purchaser's Solicitor Contact Information:
image

Only provider one of the options (Purchaser as Corporation or Individual):
image

Agreement Date:
image

Confluence
Jira Ticket

@areyeslo areyeslo marked this pull request as draft February 19, 2026 18:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@areyeslo areyeslo force-pushed the PSP-10827-H-0179-RC branch from d82077a to c789528 Compare February 19, 2026 20:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@areyeslo areyeslo force-pushed the PSP-10827-H-0179-RC branch from c789528 to 826c8d4 Compare February 19, 2026 20:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

eddherrera
eddherrera reviewed Feb 19, 2026
View reviewed changes
Comment thread source/backend/dal/Repositories/DispositionFileRepository.cs Outdated
eddherrera
eddherrera reviewed Feb 19, 2026
View reviewed changes
Comment thread source/backend/dal/Repositories/DispositionFileRepository.cs Outdated
eddherrera
eddherrera reviewed Feb 19, 2026
View reviewed changes
Comment thread source/backend/dal/Repositories/DispositionFileRepository.cs
@areyeslo areyeslo marked this pull request as ready for review February 19, 2026 21:36
@areyeslo areyeslo force-pushed the PSP-10827-H-0179-RC branch from 826c8d4 to f0c2870 Compare February 19, 2026 21:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@areyeslo areyeslo force-pushed the PSP-10827-H-0179-RC branch from f0c2870 to 3ef1584 Compare February 19, 2026 23:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@areyeslo areyeslo self-assigned this Feb 20, 2026
@areyeslo areyeslo added the enhancement New feature or request label Feb 20, 2026
devinleighsmith
devinleighsmith reviewed Feb 20, 2026
View reviewed changes
Comment thread source/backend/dal/Repositories/DispositionFileRepository.cs
@devinleighsmith
Copy link
Copy Markdown
Collaborator

devinleighsmith commented Feb 20, 2026

Quality Gate Passed Quality Gate passed

Issues 8 New issues 0 Accepted issues

Measures 0 Security Hotspots 0.0% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@areyeslo please review the report and either clear these warnings or correct them.

devinleighsmith
devinleighsmith reviewed Feb 20, 2026
View reviewed changes
Comment thread source/backend/api/Areas/Disposition/Controllers/DispositionFileController.cs Outdated
devinleighsmith
devinleighsmith requested changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, repository method must be changed.

@areyeslo areyeslo force-pushed the PSP-10827-H-0179-RC branch from ba7fe87 to b935bdc Compare February 23, 2026 17:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@areyeslo areyeslo force-pushed the PSP-10827-H-0179-RC branch from 6afe3c3 to fd3642c Compare February 23, 2026 20:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@areyeslo areyeslo force-pushed the PSP-10827-H-0179-RC branch from ffb0491 to ce9f6b3 Compare February 23, 2026 21:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 23, 2026

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5220

@areyeslo areyeslo added this pull request to the merge queue Feb 23, 2026
Merged via the queue into bcgov:dev with commit d79b270 Feb 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devinleighsmith devinleighsmith devinleighsmith approved these changes

@asanchezr asanchezr Awaiting requested review from asanchezr

@eddherrera eddherrera Awaiting requested review from eddherrera

Assignees

@areyeslo areyeslo

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@areyeslo @devinleighsmith @eddherrera @github-advanced-security