Skip to content

PSP-11135 Display Lat/Long Decimal Coordinates as “x/y”#5246

Merged
asanchezr merged 15 commits intobcgov:devfrom
asanchezr:psp-11135-lat-long-display
Mar 12, 2026
Merged

PSP-11135 Display Lat/Long Decimal Coordinates as “x/y”#5246
asanchezr merged 15 commits intobcgov:devfrom
asanchezr:psp-11135-lat-long-display

Conversation

@asanchezr
Copy link
Collaborator

Quick-info, Property picker and working list

Property_lat_long_display image

Document Search

DocumentSearch_fixed

Management reports

Management_activities_report

Lease reports

Lease_payments_report

@asanchezr asanchezr self-assigned this Mar 8, 2026
@asanchezr asanchezr added enhancement New feature or request 6.1 labels Mar 8, 2026
{
Pid = property?.Pid != null ? property.Pid.ToString() : null;
Pin = property?.Pin != null ? property.Pin.ToString() : null;
SurveyPlanNumber = !string.IsNullOrEmpty(property?.SurveyPlanNumber) ? property?.SurveyPlanNumber : null;

Check warning

Code scanning / CodeQL

Constant condition Warning

Condition is always not null because of
call to method IsNullOrEmpty
.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5246

@asanchezr asanchezr force-pushed the psp-11135-lat-long-display branch from cab9afb to 38fb610 Compare March 9, 2026 22:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5246

@areyeslo
Copy link
Collaborator

LGTM, only needs to fix the tests failing and naming conventions in the two controllers.

@asanchezr asanchezr force-pushed the psp-11135-lat-long-display branch from 38fb610 to d292381 Compare March 12, 2026 04:41
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5246

@github-actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5246

@asanchezr asanchezr added this pull request to the merge queue Mar 12, 2026
Merged via the queue into bcgov:dev with commit a2a3a6a Mar 12, 2026
15 of 22 checks passed
@asanchezr asanchezr deleted the psp-11135-lat-long-display branch March 12, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.1 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants