PSP-10923: Adding index to elements, refining automated test cases#5255
PSP-10923: Adding index to elements, refining automated test cases#5255
Conversation
…nto playwright-branch
…nto playwright-branch
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5255 |
asanchezr
left a comment
asanchezr
left a comment
There was a problem hiding this comment.
Looks good! Only one minor comment
| export const PropertyImprovementDetails: React.FunctionComponent< | ||
| IPropertyImprovementDetailsProps | ||
| > = ({ propertyImprovement }) => { | ||
| > = ({ propertyImprovement, propertyImprovementIndex }) => { |
There was a problem hiding this comment.
Since the propertyImprovementIndex property is marked as nullable, we would need to provide a default value in case we get null/undefined here. This is needed because the value is used in the valueTestId strings below...
Something like:
| > = ({ propertyImprovement, propertyImprovementIndex }) => { | |
| > = ({ propertyImprovement, propertyImprovementIndex = 0}) => { |
|
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5255 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5255 |
3 participants
No description provided.