PSP-11307: Management Property management. Cancel of Add Contact#5260
Merged
PSP-11307: Management Property management. Cancel of Add Contact#5260
Conversation
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5260 |
asanchezr
reviewed
Mar 23, 2026
areyeslo
force-pushed
the
PSP-11307-Management-CancelAddContact
branch
from
0fc6590 to
1d95612
Compare
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5260 |
|
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5260 |
asanchezr
approved these changes
Mar 24, 2026
Collaborator
asanchezr
left a comment
asanchezr
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ManagementView exposes Cancel button through SidebarFooter which receives a prop onCancel from the Container. Currently, the Container only redirects the user to
/mapview/sidebar/management/id/fileDetails. We need to add the logic to check if the user is under File Properties context and redirect the user to the appropriate route. We are removing ConfirmNavigation as it is blocking the routing when form is pristine.Jira