PSP-11291 : Add Advance Payment Date and Agreement Signed Date#5265
Merged
eddherrera merged 4 commits intobcgov:devfrom Mar 26, 2026
Merged
PSP-11291 : Add Advance Payment Date and Agreement Signed Date#5265eddherrera merged 4 commits intobcgov:devfrom
eddherrera merged 4 commits intobcgov:devfrom
Conversation
Collaborator
eddherrera
commented
Mar 25, 2026
eddherrera
commented
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5265 |
1 similar comment
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5265 |
asanchezr
approved these changes
Mar 26, 2026
Comment on lines
+68
to
+70
| const isSection3 = | ||
| (file as unknown as ApiGen_Concepts_AcquisitionFile)?.acquisitionTypeCode?.id === | ||
| ApiGen_CodeTypes_AcquisitionFileTypeTypes.SECTN3; |
Collaborator
There was a problem hiding this comment.
nit: this component already receives the acquisitionFile as a prop - not sure we need to get the file from the context.
Collaborator
Author
There was a problem hiding this comment.
Good point. I am not sure but seems ideal to use the prop one.
added 2 commits
March 26, 2026 09:26
|
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5265 |
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.