PSP-11366 : Add new Program Type to Lease/Licence drop-down Options#5293
Merged
PSP-11366 : Add new Program Type to Lease/Licence drop-down Options#5293
Conversation
asanchezr
reviewed
Apr 22, 2026
Comment on lines
29
to
33
| IF @@ROWCOUNT = 1 | ||
| UPDATE PIMS_LEASE_PROGRAM_TYPE | ||
| SET IS_DISABLED = 0 | ||
| SET IS_DISABLED = 1 | ||
| , CONCURRENCY_CONTROL_NUMBER = CONCURRENCY_CONTROL_NUMBER + 1 | ||
| WHERE LEASE_PROGRAM_TYPE_CODE = @CurrCd; |
Collaborator
There was a problem hiding this comment.
In my opinion this whole file should be deleted. "Pretend it never existed" because we will alter down the lower environments before re-applying the PR targeting the correct table PIMS_LEASE_LICENSE_TYPE
No need to keep this logic and keep a code disabled unnecessarily
asanchezr
reviewed
Apr 22, 2026
Comment on lines
26
to
28
| PRINT '- Executing PSP_PIMS_S120_00/Alter Down/057_DML_PIMS_LEASE_PROGRAM_TYPE_Alter_Down.sql ' | ||
| :setvar filepath "PSP_PIMS_S120_00/Alter Down/057_DML_PIMS_LEASE_PROGRAM_TYPE_Alter_Down.sql" | ||
| :r $(filepath) |
Collaborator
There was a problem hiding this comment.
In my opinion we should not be running alter downs and ups for the wrong table . Only leave the alters for PIMS_LEASE_LICENSE_TYPE
asanchezr
reviewed
Apr 22, 2026
| @@ -0,0 +1,51 @@ | |||
| -- ------------------------------------------------------------------------------------------- | |||
| -- Alter the PIMS_LEASE_PROGRAM_TYPE table. | |||
Collaborator
There was a problem hiding this comment.
nit: the comment is mentioning the wrong table. This script is modifying PIMS_LEASE_LICENSE_TYPE
asanchezr
reviewed
Apr 22, 2026
| @@ -0,0 +1,75 @@ | |||
| -- ------------------------------------------------------------------------------------------- | |||
| -- Alter the PIMS_LEASE_PROGRAM_TYPE table. | |||
added 2 commits
April 22, 2026 15:31
|
asanchezr
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.