[CHORE]: reduce number of queries for location table#122
Merged
chelsea-EYDS merged 4 commits intomainfrom Jun 7, 2023
Merged
Conversation
chelsea-EYDS
force-pushed
the
locations-norm
branch
from
468314a to
8a60053
Compare
fw-noel
reviewed
Jun 5, 2023
Collaborator
fw-noel
left a comment
fw-noel
left a comment
There was a problem hiding this comment.
I like this PR a lot! Please address comments
| }); | ||
| return this.normalizeLocations(locations); | ||
| } | ||
| public normalizeLocations(locations: LocationEntity[]): NormalizedLocation[] { |
Contributor
Author
There was a problem hiding this comment.
done (not showing here as outdated but can be seen in diff...)
| description: '', | ||
| }; | ||
| } | ||
| itm.merchant_id !== 999999999 && |
Collaborator
There was a problem hiding this comment.
I know why because you explained it to me, but this should be commented on why. We may also want to define 999999999 as a constant. We always want to avoid magic numbers
| } | ||
| itm.merchant_id !== 999999999 && | ||
| acc[key].merchant_ids.push(itm.merchant_id); | ||
| if (itm.method === 'Bank') { |
Collaborator
There was a problem hiding this comment.
use LocationMethod enum since it exists?
fw-noel
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHORE
Objective: