[CCFPCM-0498] Report updates (post rounds 3/4 heuristics)#123
Merged
chelsea-EYDS merged 12 commits intomainfrom Jun 8, 2023
Merged
[CCFPCM-0498] Report updates (post rounds 3/4 heuristics)#123chelsea-EYDS merged 12 commits intomainfrom
chelsea-EYDS merged 12 commits intomainfrom
Conversation
chelsea-EYDS
force-pushed
the
CCFPCM-498-reports
branch
from
820b044 to
646db60
Compare
chelsea-EYDS
changed the title
chelsea-EYDS
force-pushed
the
CCFPCM-498-reports
branch
from
646db60 to
0da90c8
Compare
fw-noel
reviewed
Jun 7, 2023
apps/backend/src/lambdas/report.ts
Outdated
| ); | ||
| }; | ||
|
|
||
| const cashReportData = async ( |
Collaborator
There was a problem hiding this comment.
Suggested change
| const cashReportData = async ( | |
| const getCashReportData = async ( |
Collaborator
There was a problem hiding this comment.
And as usual, comment block please
apps/backend/src/lambdas/report.ts
Outdated
| }; | ||
| }; | ||
|
|
||
| const posReportData = async ( |
Collaborator
There was a problem hiding this comment.
Suggested change
| const posReportData = async ( | |
| const getPosReportData = async ( |
fw-noel
reviewed
Jun 7, 2023
apps/backend/src/lambdas/report.ts
Outdated
| ); | ||
| const matchedDepositIdsFromPayments = | ||
| matchedPayments.map((itm: PaymentEntity) => itm.pos_deposit_match) ?? []; | ||
| /*eslint-disable */ |
chelsea-EYDS
force-pushed
the
CCFPCM-498-reports
branch
from
6c4be6c to
20964c6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
fw-noel
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCFPCM-0498
Objective: