Skip to content

[CCFPCM-0526] bugfix - heuristic 3#126

Merged
chelsea-EYDS merged 3 commits intomainfrom
CCFPCM-526-bugfix
Jun 7, 2023
Merged

[CCFPCM-0526] bugfix - heuristic 3#126
chelsea-EYDS merged 3 commits intomainfrom
CCFPCM-526-bugfix

Conversation

@chelsea-EYDS
Copy link
Contributor

CCFPCM-0526

Objective:

  • only match round three POS if deposit date is before payment date

@chelsea-EYDS chelsea-EYDS changed the title Ccfpcm 526 bugfix [CCFPCM-0526] bugfix - heuristic 3 Jun 7, 2023
fw-noel
fw-noel previously approved these changes Jun 7, 2023
const dayAfterDateToFind = addBusinessDaysNoTimezone(dateToFind, 1);
deposits =
depositsWithAmount[`${dayAfterDateToFind}-${paymentMethod}`];
if (!deposits?.length) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this if case can be removed? Already checked in line 242

@fw-noel fw-noel self-requested a review June 7, 2023 04:44
@fw-noel fw-noel dismissed their stale review June 7, 2023 18:22

Not actually approved

@chelsea-EYDS chelsea-EYDS merged commit 72eea35 into main Jun 7, 2023
@chelsea-EYDS chelsea-EYDS deleted the CCFPCM-526-bugfix branch June 7, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants