Skip to content

Testrepo#14

Merged
chelsea-EYDS merged 6 commits intomainfrom
testrepo
Dec 1, 2022
Merged

Testrepo#14
chelsea-EYDS merged 6 commits intomainfrom
testrepo

Conversation

@chelsea-EYDS
Copy link
Contributor

@chelsea-EYDS chelsea-EYDS commented Nov 28, 2022

What has changed:

  • Removed root level package.json/node_modules/yarn stuff
  • Updated backend tsconfig and jest.config
  • created docker build/container for local and test
  • updated docker-compose
  • added makefile commands to build/run local and test

@chelsea-EYDS chelsea-EYDS force-pushed the testrepo branch 2 times, most recently from fe608a2 to f304334 Compare November 28, 2022 21:43
Copy link
Contributor

@vyasworks vyasworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just few qns.

Pls clarify what you meant by moving backend one folder up :)

tags:
- dev
env:
TF_VERSION: 1.2.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove TF Version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just few qns.

Pls clarify what you meant by moving backend one folder up :)

Oops! I un-did this to avoid an even bigger diff. Also, I wasn't sure if the zipped prod build referenced the current file path so I thought it would be better to leave it as is.

@@ -1,28 +0,0 @@
/* eslint-disable */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we downgrading from yarn3

# BUILD FOR PRODUCTION
###################

FROM node:16-alpine3.16 AS build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will run the apps as lambdas,

but curious why the production build is in the same file as local build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've included the production build only for testing purposes (ie testing the build/prod version). We are specifying the build target in the docker-compose so the steps to build for production will likely go un-used.

I also wasn't sure if we'd continue to build and run the lambdas from the zipped code or possibly use a docker image in the lambda.

The reason for using incremental builds in the Dockerfile, is (from what I understand): the build itself will be faster, the image smaller, and there will be consistency between the dev/prod images.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I am not sure if I have done the incremental build properly though :)

on:
push:
tags:
- dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also run on PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks!

@chelsea-EYDS chelsea-EYDS force-pushed the testrepo branch 5 times, most recently from c57a160 to 17ce3f2 Compare November 30, 2022 23:07
@chelsea-EYDS chelsea-EYDS merged commit 0aab425 into main Dec 1, 2022
@chelsea-EYDS chelsea-EYDS deleted the testrepo branch January 10, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants