Skip to content

[FIX] filtering zero amount in parse garms#65

Merged
chelsea-EYDS merged 1 commit intomainfrom
FIX-zero-amts
Mar 2, 2023
Merged

[FIX] filtering zero amount in parse garms#65
chelsea-EYDS merged 1 commit intomainfrom
FIX-zero-amts

Conversation

@chelsea-EYDS
Copy link
Contributor

@chelsea-EYDS chelsea-EYDS commented Mar 2, 2023 •
edited
Loading

CCFPCM-0000

Objective:

  • Filter out zero dollar amount when parsing garms SBC files
  • Update cash payments query
  • Write migration to remove current zero dollar amount payments from the db

vyasworks
vyasworks reviewed Mar 2, 2023
View reviewed changes
@vyasworks
Copy link
Contributor

vyasworks commented Mar 2, 2023

Just had a chat with Karim abt this, he wants to remove these entries from garms so ✔️ for me.

@chelsea-EYDS chelsea-EYDS merged commit 5149027 into main Mar 2, 2023
@chelsea-EYDS chelsea-EYDS deleted the FIX-zero-amts branch March 22, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwarrenbc jwarrenbc Awaiting requested review from jwarrenbc

1 more reviewer

@vyasworks vyasworks vyasworks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chelsea-EYDS @vyasworks