[FIX] cash location_ids

[chelsea-EYDS]

FIX

Objective:

• When the column for the pt_location_ids in the cash deposit table was last updated, the logic for the location lookup for cash reconciliation had an error if a location id was passed in with the reconciliation event. If a location_id is passed in to the recon event, this location_id should be used to lookup pt_location_ids, rather than expecting a pt_location_id to be passed in with the event.

[jwarrenbc]

This range is just for testing purposes, right? What's the best way to mark it so that it gets changed to the real fiscal year before this is being used in production?

[chelsea-EYDS]

I think we could remove the dates from the event and just use an environment variable to set the date. If the plan is to run reconciliation daily starting from the start of the fiscal year, or quarter, etc, then we shouldn't need to pass these in.
We also probably don't need the option to pass in locations or programs either. It makes sense to look up by location for reporting, but if this is meant to run daily for all locations and programs then we can set these with env vars... I think we weren't clear on the criteria so it was left as flexible as possible for the time being.

[chelsea-EYDS]

(I think this is something we should clarify with the team though and could be handled in another PR as this one will unblock testing).

[jwarrenbc]

TO DO: figure out how to handle fiscal dates